chrome/browser/lifetime/keep_alive_types.cc - Issue 1885933002: Ensure that DLOG(FATAL) also asserts in release-with-asserts builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/lifetime/keep_alive_types.cc

Issue 1885933002: Ensure that DLOG(FATAL) also asserts in release-with-asserts builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add comment with installer fix Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/lifetime/keep_alive_types.cc

diff --git a/chrome/browser/lifetime/keep_alive_types.cc b/chrome/browser/lifetime/keep_alive_types.cc

index 13a40e0901682a217fd2c7fe02abffb3dc1dabef..173f417eaee7077899e718db72f89a43842db297 100644

--- a/chrome/browser/lifetime/keep_alive_types.cc

+++ b/chrome/browser/lifetime/keep_alive_types.cc

@@ -5,7 +5,7 @@

#include "chrome/browser/lifetime/keep_alive_types.h"

#include "base/logging.h"

-#ifndef NDEBUG

+#if !defined(NDEBUG) || defined(DCHECK_ALWAYS_ON)

std::ostream& operator<<(std::ostream& out, const KeepAliveOrigin& origin) {

switch (origin) {

case KeepAliveOrigin::APP_CONTROLLER:

@@ -59,4 +59,4 @@ std::ostream& operator<<(std::ostream& out,

return out << static_cast<int>(restart);

}

-#endif // ndef NDEBUG

+#endif

« no previous file with comments | « chrome/browser/lifetime/keep_alive_types.h ('k') | media/base/key_systems_unittest.cc » ('j') | no next file with comments »