Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(916)

Unified Diff: media/base/key_systems_unittest.cc

Issue 1885933002: Ensure that DLOG(FATAL) also asserts in release-with-asserts builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add comment with installer fix Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/lifetime/keep_alive_types.cc ('k') | net/spdy/hpack/hpack_huffman_decoder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/key_systems_unittest.cc
diff --git a/media/base/key_systems_unittest.cc b/media/base/key_systems_unittest.cc
index 44b881939c93424058b09646fdb36c6f94f619a5..619a5c97b17e97a0d876cef6bc14cbb1c332980f 100644
--- a/media/base/key_systems_unittest.cc
+++ b/media/base/key_systems_unittest.cc
@@ -401,8 +401,10 @@ TEST_F(KeySystemsTest, Basic_UnrecognizedKeySystem) {
#if defined(ENABLE_PEPPER_CDMS)
std::string type;
- EXPECT_DEBUG_DEATH(type = GetPepperType(kUnrecognized),
- "x-org.example.unrecognized is not a known system");
+#if !defined(NDEBUG) || defined(DCHECK_ALWAYS_ON)
+ EXPECT_DEATH(type = GetPepperType(kUnrecognized),
+ "x-org.example.unrecognized is not a known system");
+#endif
EXPECT_TRUE(type.empty());
#endif
}
@@ -418,8 +420,10 @@ TEST_F(KeySystemsTest, Basic_UsesAesDecryptor) {
EXPECT_TRUE(CanUseAesDecryptor(kUsesAes));
#if defined(ENABLE_PEPPER_CDMS)
std::string type;
- EXPECT_DEBUG_DEATH(type = GetPepperType(kUsesAes),
- "x-org.example.clear is not Pepper-based");
+#if !defined(NDEBUG) || defined(DCHECK_ALWAYS_ON)
+ EXPECT_DEATH(type = GetPepperType(kUsesAes),
+ "x-org.example.clear is not Pepper-based");
+#endif
EXPECT_TRUE(type.empty());
#endif
}
« no previous file with comments | « chrome/browser/lifetime/keep_alive_types.cc ('k') | net/spdy/hpack/hpack_huffman_decoder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698