Site Settings: Use only string values for permissions on the JS side.

Site Settings: Use only string values for permissions on the JS side.

This also fixes a couple of Closure errors and improves the handling for pattern combinations containing embedded origins.

BUG=602899, 543635
Committed: https://crrev.com/f6d59b7cd346f67ec764d4da72ca4983a4d2d537
Cr-Commit-Position: refs/heads/master@{#387127}

[Finnur, 2016-04-13 12:49:35]

Description was changed from

==========
Site Settings: Use only string values for permissions on the JS side.

BUG=543635
==========

to

==========
Site Settings: Use only string values for permissions on the JS side.

This also fixes a couple of Closure errors and improves the handling for
patterns combinations containing embedded origins.

BUG=602899, 543635
==========

[Finnur, 2016-04-13 12:49:35]

finnur@chromium.org changed reviewers:
+ tommycli@chromium.org

[Finnur, 2016-04-13 12:58:08]

Description was changed from

==========
Site Settings: Use only string values for permissions on the JS side.

This also fixes a couple of Closure errors and improves the handling for
patterns combinations containing embedded origins.

BUG=602899, 543635
==========

to

==========
Site Settings: Use only string values for permissions on the JS side.

This also fixes a couple of Closure errors and improves the handling for pattern
combinations containing embedded origins.

BUG=602899, 543635
==========

[michaelpg, 2016-04-13 16:40:15]

michaelpg@chromium.org changed reviewers:
+ michaelpg@chromium.org

[michaelpg, 2016-04-13 16:40:16]

https://codereview.chromium.org/1882793002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/site_settings/site_details_permission.js
(right):

https://codereview.chromium.org/1882793002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/site_details_permission.js:96:
this.site.origin, '', this.category, value);
why are these switched

[michaelpg, 2016-04-13 16:40:42]

michaelpg@chromium.org changed reviewers:
- michaelpg@chromium.org

[michaelpg, 2016-04-13 16:40:42]

oops.. i'm on the wrong cl

[Finnur, 2016-04-13 18:05:47]

https://codereview.chromium.org/1882793002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/site_settings/site_details_permission.js
(right):

https://codereview.chromium.org/1882793002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/site_details_permission.js:96:
this.site.origin, '', this.category, value);
You'll find the answer in site_settings_behavior.js (hint: the params there were
accidentally reversed).

[tommycli, 2016-04-13 18:21:29]

lgtm sans nit below:

https://codereview.chromium.org/1882793002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js
(right):

https://codereview.chromium.org/1882793002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js:66:
* @param {!string} primaryPattern The origin to change (primary pattern).
nit: These primitive types, string, number are non-nullable by default and don't
need the '!' declaration. Just @param {string} is enough.

See https://developers.google.com/closure/compiler/docs/js-for-compiler#types

Here and below

[Finnur, 2016-04-13 21:44:55]

Thanks! Checking in.

https://codereview.chromium.org/1882793002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js
(right):

https://codereview.chromium.org/1882793002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js:66:
* @param {!string} primaryPattern The origin to change (primary pattern).
Done!

[Finnur, 2016-04-13 21:45:17]

The CQ bit was checked by finnur@chromium.org

[Finnur, 2016-04-13 21:45:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
tommycli@chromium.org
Link to the patchset: https://codereview.chromium.org/1882793002/#ps40001
(title: "Address feedback")

[commit-bot: I haz the power, 2016-04-13 21:45:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1882793002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1882793002/40001

[commit-bot: I haz the power, 2016-04-13 22:31:06]

Description was changed from

==========
Site Settings: Use only string values for permissions on the JS side.

This also fixes a couple of Closure errors and improves the handling for pattern
combinations containing embedded origins.

BUG=602899, 543635
==========

to

==========
Site Settings: Use only string values for permissions on the JS side.

This also fixes a couple of Closure errors and improves the handling for pattern
combinations containing embedded origins.

BUG=602899, 543635
==========

[commit-bot: I haz the power, 2016-04-13 22:31:07]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-13 22:33:10]

Description was changed from

==========
Site Settings: Use only string values for permissions on the JS side.

This also fixes a couple of Closure errors and improves the handling for pattern
combinations containing embedded origins.

BUG=602899, 543635
==========

to

==========
Site Settings: Use only string values for permissions on the JS side.

This also fixes a couple of Closure errors and improves the handling for pattern
combinations containing embedded origins.

BUG=602899, 543635

Committed: https://crrev.com/f6d59b7cd346f67ec764d4da72ca4983a4d2d537
Cr-Commit-Position: refs/heads/master@{#387127}
==========

[commit-bot: I haz the power, 2016-04-13 22:33:11]

Patchset 3 (id:??) landed as
https://crrev.com/f6d59b7cd346f67ec764d4da72ca4983a4d2d537
Cr-Commit-Position: refs/heads/master@{#387127}