Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6799)

Unified Diff: chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc

Issue 1882793002: Site Settings: Use only string values for permissions on the JS side. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address feedback Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/settings/site_settings_handler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc
diff --git a/chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc b/chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc
index 4b32c41293806289e0318b28ef4277e234201669..fd388022fd7548e4e337a23ebcc9d01b81ffe0c1 100644
--- a/chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc
+++ b/chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc
@@ -125,7 +125,7 @@ TEST_F(SiteSettingsHandlerTest, GetAndSetDefault) {
// Set the default to 'Blocked'.
base::ListValue setArgs;
setArgs.Append(new base::FundamentalValue(type));
- setArgs.Append(new base::FundamentalValue(CONTENT_SETTING_BLOCK));
+ setArgs.Append(new base::StringValue("block"));
handler.HandleSetDefaultValueForContentType(&setArgs);
EXPECT_EQ(2U, web_ui()->call_data().size());
@@ -148,7 +148,7 @@ TEST_F(SiteSettingsHandlerTest, Origins) {
setArgs.Append(new base::StringValue(google)); // Primary pattern.
setArgs.Append(new base::StringValue(google)); // Secondary pattern.
setArgs.Append(new base::FundamentalValue(type));
- setArgs.Append(new base::FundamentalValue(CONTENT_SETTING_BLOCK));
+ setArgs.Append(new base::StringValue("block"));
handler.HandleSetCategoryPermissionForOrigin(&setArgs);
EXPECT_EQ(1U, web_ui()->call_data().size());
« no previous file with comments | « chrome/browser/ui/webui/settings/site_settings_handler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698