chrome/browser/resources/settings/site_settings/site_details_permission.html - Issue 1882793002: Site Settings: Use only string values for permissions on the JS side.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/site_settings/site_details_permission.html

Issue 1882793002: Site Settings: Use only string values for permissions on the JS side. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address feedback Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/site_settings/constants.js ('k') | chrome/browser/resources/settings/site_settings/site_details_permission.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/site_settings/site_details_permission.html

diff --git a/chrome/browser/resources/settings/site_settings/site_details_permission.html b/chrome/browser/resources/settings/site_settings/site_details_permission.html

index 17c189479c12e821d6f15fcaf1a75a0fc4066b8c..b51ecce0ba43d46fb9a1d8c1b21bd11e630920ee 100644

--- a/chrome/browser/resources/settings/site_settings/site_details_permission.html

+++ b/chrome/browser/resources/settings/site_settings/site_details_permission.html

@@ -33,11 +33,11 @@

on-iron-activate="onPermissionMenuIronActivate_"

attr-for-selected="data-permission-value">

<paper-item id="allow"

- data-permission-value$="[[PermissionStringValues.ALLOW]]">

+ data-permission-value$="[[PermissionValues.ALLOW]]">

[[i18n_.allowAction]]

</paper-item>

<paper-item id="block"

- data-permission-value$="[[PermissionStringValues.BLOCK]]">

+ data-permission-value$="[[PermissionValues.BLOCK]]">

[[i18n_.blockAction]]

</paper-item>

</paper-menu>