chrome/browser/resources/settings/site_settings/site_settings_behavior.js - Issue 1882793002: Site Settings: Use only string values for permissions on the JS side.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/site_settings/site_settings_behavior.js

Issue 1882793002: Site Settings: Use only string values for permissions on the JS side. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address feedback Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/site_settings/site_list.js ('k') | chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/site_settings/site_settings_behavior.js

diff --git a/chrome/browser/resources/settings/site_settings/site_settings_behavior.js b/chrome/browser/resources/settings/site_settings/site_settings_behavior.js

index e15c22119c977d4c201fc00bd1798b81db4f97ad..599015405257dc78e5ebc1c7edf8119386e2629e 100644

--- a/chrome/browser/resources/settings/site_settings/site_settings_behavior.js

+++ b/chrome/browser/resources/settings/site_settings/site_settings_behavior.js

@@ -49,12 +49,12 @@ var SiteSettingsBehaviorImpl = {

* for.

* @param {string} secondaryPattern The secondary pattern to change the

* permission for.

- * @param {number} value What value to set the permission to.

* @param {number} category The category permission to change.

+ * @param {string} value What value to set the permission to.

* @protected

setCategoryPermissionForOrigin: function(

- primaryPattern, secondaryPattern, value, category) {

+ primaryPattern, secondaryPattern, category, value) {

this.browserProxy.setCategoryPermissionForOrigin(

primaryPattern, secondaryPattern, category, value);