Site Settings: Use only string values for permissions on the JS side.

chrome/browser/resources/settings/site_settings/site_details_permission.js

Index: chrome/browser/resources/settings/site_settings/site_details_permission.js
diff --git a/chrome/browser/resources/settings/site_settings/site_details_permission.js b/chrome/browser/resources/settings/site_settings/site_details_permission.js
index eee4810b9d90676b33318b9ff863a7f33cb4b83b..552ad5b5f90c2fa8b763f8be966c5c770fef819b 100644
--- a/chrome/browser/resources/settings/site_settings/site_details_permission.js
+++ b/chrome/browser/resources/settings/site_settings/site_details_permission.js
@@ -35,7 +35,7 @@ Polymer({
 
   /** @override */
   attached: function() {
-    this.PermissionStringValues = settings.PermissionStringValues;
+    this.PermissionValues = settings.PermissionValues;
     this.addWebUIListener('contentSettingSitePermissionChanged',
         this.sitePermissionChanged_.bind(this));
   },
@@ -88,19 +88,11 @@ Polymer({
 
   /**
    * Handles the category permission changing for this origin.
-   * @param {!{detail: !{item: !{innerText: string}}}} event
+   * @param {!{detail: !{item: !{dataset: !{permissionValue: string}}}}} event
    */
   onPermissionMenuIronActivate_: function(event) {
-    var action = event.detail.item.dataset.permissionValue;
-    var value = '';
-    if (action == settings.PermissionStringValues.ALLOW)
-      value = settings.PermissionValues.ALLOW;
-    else if (action == settings.PermissionStringValues.BLOCK)
-      value = settings.PermissionValues.BLOCK;
-    else
-      assertNotReached('Invalid menu item ' + action);
-
+    var value = event.detail.item.dataset.permissionValue;
     this.setCategoryPermissionForOrigin(
-        this.site.origin, '', value, this.category);
+        this.site.origin, '', this.category, value);
   },
 });