Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Side by Side Diff: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Issue 1882793002: Site Settings: Use only string values for permissions on the JS side. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address feedback Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/settings/md_settings_localized_strings_provide r.h" 5 #include "chrome/browser/ui/webui/settings/md_settings_localized_strings_provide r.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/strings/utf_string_conversions.h" 10 #include "base/strings/utf_string_conversions.h"
(...skipping 732 matching lines...) Expand 10 before | Expand all | Expand 10 after
743 IDS_SETTINGS_SEARCH_ENGINES_REMOVE_FROM_LIST}, 743 IDS_SETTINGS_SEARCH_ENGINES_REMOVE_FROM_LIST},
744 {"searchEnginesManageExtension", 744 {"searchEnginesManageExtension",
745 IDS_SETTINGS_SEARCH_ENGINES_MANAGE_EXTENSION}, 745 IDS_SETTINGS_SEARCH_ENGINES_MANAGE_EXTENSION},
746 }; 746 };
747 AddLocalizedStringsBulk(html_source, localized_strings, 747 AddLocalizedStringsBulk(html_source, localized_strings,
748 arraysize(localized_strings)); 748 arraysize(localized_strings));
749 } 749 }
750 750
751 void AddSiteSettingsStrings(content::WebUIDataSource* html_source) { 751 void AddSiteSettingsStrings(content::WebUIDataSource* html_source) {
752 LocalizedString localized_strings[] = { 752 LocalizedString localized_strings[] = {
753 {"embeddedOnHost", IDS_EXCEPTIONS_GEOLOCATION_EMBEDDED_ON_HOST},
753 {"siteSettingsCategoryPageTitle", IDS_SETTINGS_SITE_SETTINGS_CATEGORY}, 754 {"siteSettingsCategoryPageTitle", IDS_SETTINGS_SITE_SETTINGS_CATEGORY},
754 {"siteSettingsCategoryAllSites", IDS_SETTINGS_SITE_SETTINGS_ALL_SITES}, 755 {"siteSettingsCategoryAllSites", IDS_SETTINGS_SITE_SETTINGS_ALL_SITES},
755 {"siteSettingsCategoryCamera", IDS_SETTINGS_SITE_SETTINGS_CAMERA}, 756 {"siteSettingsCategoryCamera", IDS_SETTINGS_SITE_SETTINGS_CAMERA},
756 {"siteSettingsCategoryCookies", IDS_SETTINGS_SITE_SETTINGS_COOKIES}, 757 {"siteSettingsCategoryCookies", IDS_SETTINGS_SITE_SETTINGS_COOKIES},
757 {"siteSettingsCategoryFullscreen", IDS_SETTINGS_SITE_SETTINGS_FULLSCREEN}, 758 {"siteSettingsCategoryFullscreen", IDS_SETTINGS_SITE_SETTINGS_FULLSCREEN},
758 {"siteSettingsCategoryImages", IDS_SETTINGS_SITE_SETTINGS_IMAGES}, 759 {"siteSettingsCategoryImages", IDS_SETTINGS_SITE_SETTINGS_IMAGES},
759 {"siteSettingsCategoryLocation", IDS_SETTINGS_SITE_SETTINGS_LOCATION}, 760 {"siteSettingsCategoryLocation", IDS_SETTINGS_SITE_SETTINGS_LOCATION},
760 {"siteSettingsCategoryJavascript", IDS_SETTINGS_SITE_SETTINGS_JAVASCRIPT}, 761 {"siteSettingsCategoryJavascript", IDS_SETTINGS_SITE_SETTINGS_JAVASCRIPT},
761 {"siteSettingsCategoryMicrophone", IDS_SETTINGS_SITE_SETTINGS_MIC}, 762 {"siteSettingsCategoryMicrophone", IDS_SETTINGS_SITE_SETTINGS_MIC},
762 {"siteSettingsCategoryNotifications", 763 {"siteSettingsCategoryNotifications",
(...skipping 177 matching lines...) Expand 10 before | Expand all | Expand 10 after
940 #endif 941 #endif
941 AddUsersStrings(html_source); 942 AddUsersStrings(html_source);
942 AddWebContentStrings(html_source); 943 AddWebContentStrings(html_source);
943 944
944 policy_indicator::AddLocalizedStrings(html_source); 945 policy_indicator::AddLocalizedStrings(html_source);
945 946
946 html_source->SetJsonPath(kLocalizedStringsFile); 947 html_source->SetJsonPath(kLocalizedStringsFile);
947 } 948 }
948 949
949 } // namespace settings 950 } // namespace settings
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698