Convert ContentSettingBubbleContents to a BubbleDialogDelegate

Convert ContentSettingBubbleContents to a BubbleDialogDelegate

This one is easy to show: block some cookies, or images, or other
content, then click on the omnibox icon for the blocked content.

BUG=585312
TBR=achuith@chromium.org

Committed: https://crrev.com/6a7de16dc3bd3da6f51d4b654fdd51c7a546d7c1
Cr-Commit-Position: refs/heads/master@{#385829}

[Evan Stade, 2016-04-06 23:54:40]

estade@chromium.org changed reviewers:
+ msw@chromium.org

[Evan Stade, 2016-04-06 23:54:44]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-06 23:55:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1870533002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1870533002/20001

[commit-bot: I haz the power, 2016-04-07 00:39:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-07 00:39:35]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[msw, 2016-04-07 17:23:19]

nice, lgtm

[Evan Stade, 2016-04-07 18:10:58]

Description was changed from

==========
Convert ContentSettingBubbleContents to a BubbleDialogDelegate

This one is easy to show: block some cookies, or images, or other
content, then click on the omnibox icon for the blocked content.

BUG=585312
==========

to

==========
Convert ContentSettingBubbleContents to a BubbleDialogDelegate

This one is easy to show: block some cookies, or images, or other
content, then click on the omnibox icon for the blocked content.

BUG=585312
TBR=achuith@chromium.org
==========

[Evan Stade, 2016-04-07 18:10:58]

estade@chromium.org changed reviewers:
+ achuith@chromium.org

[Evan Stade, 2016-04-07 18:11:18]

TBR achuith for chromeos

[Evan Stade, 2016-04-07 18:15:06]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-04-07 18:15:07]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/1870533002/#ps40001
(title: "fix mac views")

[commit-bot: I haz the power, 2016-04-07 18:15:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1870533002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1870533002/40001

[commit-bot: I haz the power, 2016-04-07 19:13:25]

Description was changed from

==========
Convert ContentSettingBubbleContents to a BubbleDialogDelegate

This one is easy to show: block some cookies, or images, or other
content, then click on the omnibox icon for the blocked content.

BUG=585312
TBR=achuith@chromium.org
==========

to

==========
Convert ContentSettingBubbleContents to a BubbleDialogDelegate

This one is easy to show: block some cookies, or images, or other
content, then click on the omnibox icon for the blocked content.

BUG=585312
TBR=achuith@chromium.org
==========

[commit-bot: I haz the power, 2016-04-07 19:13:26]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-07 19:15:09]

Description was changed from

==========
Convert ContentSettingBubbleContents to a BubbleDialogDelegate

This one is easy to show: block some cookies, or images, or other
content, then click on the omnibox icon for the blocked content.

BUG=585312
TBR=achuith@chromium.org
==========

to

==========
Convert ContentSettingBubbleContents to a BubbleDialogDelegate

This one is easy to show: block some cookies, or images, or other
content, then click on the omnibox icon for the blocked content.

BUG=585312
TBR=achuith@chromium.org

Committed: https://crrev.com/6a7de16dc3bd3da6f51d4b654fdd51c7a546d7c1
Cr-Commit-Position: refs/heads/master@{#385829}
==========

[commit-bot: I haz the power, 2016-04-07 19:15:10]

Patchset 3 (id:??) landed as
https://crrev.com/6a7de16dc3bd3da6f51d4b654fdd51c7a546d7c1
Cr-Commit-Position: refs/heads/master@{#385829}

[achuithb, 2016-04-07 21:00:29]

On 2016/04/07 18:11:18, Evan Stade wrote:
> TBR achuith for chromeos

lgtm