chrome/browser/ui/views/browser_dialogs_views_mac.cc - Issue 1870533002: Convert ContentSettingBubbleContents to a BubbleDialogDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/browser_dialogs_views_mac.cc

Issue 1870533002: Convert ContentSettingBubbleContents to a BubbleDialogDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix mac views Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc ('k') | chrome/browser/ui/views/content_setting_bubble_contents.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/browser_dialogs_views_mac.cc

diff --git a/chrome/browser/ui/views/browser_dialogs_views_mac.cc b/chrome/browser/ui/views/browser_dialogs_views_mac.cc

index 7254c458d22c69d0909d423cb5bb0b8872427b98..329033aa440f8cf1a110146a1dc3694fdcb0ec17 100644

--- a/chrome/browser/ui/views/browser_dialogs_views_mac.cc

+++ b/chrome/browser/ui/views/browser_dialogs_views_mac.cc

@@ -54,7 +54,7 @@ void ContentSettingBubbleViewsBridge::Show(gfx::NativeView parent_view,

views::BubbleBorder::Arrow::TOP_RIGHT);

contents->set_parent_window(parent_view);

contents->SetAnchorRect(gfx::Rect(anchor, gfx::Size()));

- views::BubbleDelegateView::CreateBubble(contents)->Show();

+ views::BubbleDialogDelegateView::CreateBubble(contents)->Show();

}

} // namespace chrome