chrome/browser/ui/views/location_bar/location_bar_view.h - Issue 1870533002: Convert ContentSettingBubbleContents to a BubbleDialogDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/location_bar_view.h

Issue 1870533002: Convert ContentSettingBubbleContents to a BubbleDialogDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix mac views Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/location_bar/content_setting_image_view.cc ('k') | chrome/browser/ui/views/toolbar/toolbar_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/location_bar/location_bar_view.h

diff --git a/chrome/browser/ui/views/location_bar/location_bar_view.h b/chrome/browser/ui/views/location_bar/location_bar_view.h

index 6192f60bb1e3cd6a2c1d1af5ca10ff112a34a0b7..1d08b951c604856ab8651983fa5c009f2b68d3f1 100644

--- a/chrome/browser/ui/views/location_bar/location_bar_view.h

+++ b/chrome/browser/ui/views/location_bar/location_bar_view.h

@@ -54,7 +54,6 @@ class SaveCardIconView;

}

namespace views {

-class BubbleDelegateView;

class Label;

class Widget;

}

@@ -85,10 +84,6 @@ class LocationBarView : public LocationBar,

virtual ToolbarModel* GetToolbarModel() = 0;

virtual const ToolbarModel* GetToolbarModel() const = 0;

- // Creates Widget for the given delegate.

- virtual views::Widget* CreateViewsBubble(

- views::BubbleDelegateView* bubble_delegate) = 0;

// Creates PageActionImageView. Caller gets an ownership.

virtual PageActionImageView* CreatePageActionImageView(

LocationBarView* owner,