chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc - Issue 1870533002: Convert ContentSettingBubbleContents to a BubbleDialogDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc

Issue 1870533002: Convert ContentSettingBubbleContents to a BubbleDialogDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix mac views Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/ui/simple_web_view_dialog.h ('k') | chrome/browser/ui/views/browser_dialogs_views_mac.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc

diff --git a/chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc b/chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc

index d073a91de0046fcb6e8064b3404e274475910acc..7c8b192d0f497c2a4668d9ca9e056dffc9f63f6e 100644

--- a/chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc

+++ b/chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc

@@ -35,7 +35,6 @@

#include "ui/base/l10n/l10n_util.h"

#include "ui/base/theme_provider.h"

#include "ui/views/background.h"

-#include "ui/views/bubble/bubble_delegate.h"

#include "ui/views/controls/webview/webview.h"

#include "ui/views/layout/grid_layout.h"

#include "ui/views/layout/layout_constants.h"

@@ -297,11 +296,6 @@ const ToolbarModel* SimpleWebViewDialog::GetToolbarModel() const {

return toolbar_model_.get();

}

-views::Widget* SimpleWebViewDialog::CreateViewsBubble(

- views::BubbleDelegateView* bubble_delegate) {

- return views::BubbleDelegateView::CreateBubble(bubble_delegate);

ContentSettingBubbleModelDelegate*

SimpleWebViewDialog::GetContentSettingBubbleModelDelegate() {

return bubble_model_delegate_.get();

« no previous file with comments | « chrome/browser/chromeos/login/ui/simple_web_view_dialog.h ('k') | chrome/browser/ui/views/browser_dialogs_views_mac.cc » ('j') | no next file with comments »