Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Unified Diff: chrome/browser/ui/views/content_setting_bubble_contents.h

Issue 1870533002: Convert ContentSettingBubbleContents to a BubbleDialogDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix mac views Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/content_setting_bubble_contents.h
diff --git a/chrome/browser/ui/views/content_setting_bubble_contents.h b/chrome/browser/ui/views/content_setting_bubble_contents.h
index 86b2e1047a1a6e92e6925139c1e112a7bea262d6..46689f1240006563b52ae2718f149850d4dcf95c 100644
--- a/chrome/browser/ui/views/content_setting_bubble_contents.h
+++ b/chrome/browser/ui/views/content_setting_bubble_contents.h
@@ -12,7 +12,7 @@
#include "components/content_settings/core/common/content_settings_types.h"
#include "content/public/browser/web_contents_observer.h"
#include "content/public/common/media_stream_request.h"
-#include "ui/views/bubble/bubble_delegate.h"
+#include "ui/views/bubble/bubble_dialog_delegate.h"
#include "ui/views/controls/button/button.h"
#include "ui/views/controls/button/menu_button_listener.h"
#include "ui/views/controls/link_listener.h"
@@ -46,7 +46,7 @@ class RadioButton;
// get to a more comprehensive settings management dialog. A few types have
// more or fewer controls than this.
class ContentSettingBubbleContents : public content::WebContentsObserver,
- public views::BubbleDelegateView,
+ public views::BubbleDialogDelegateView,
public views::ButtonListener,
public views::LinkListener,
public views::MenuButtonListener {
@@ -65,8 +65,11 @@ class ContentSettingBubbleContents : public content::WebContentsObserver,
const std::string& label);
protected:
- // views::BubbleDelegateView:
+ // views::BubbleDialogDelegateView:
void Init() override;
+ View* CreateExtraView() override;
+ int GetDialogButtons() const override;
+ base::string16 GetDialogButtonLabel(ui::DialogButton button) const override;
private:
class Favicon;
« no previous file with comments | « chrome/browser/ui/views/browser_dialogs_views_mac.cc ('k') | chrome/browser/ui/views/content_setting_bubble_contents.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698