chrome/browser/ui/views/location_bar/content_setting_image_view.cc - Issue 1870533002: Convert ContentSettingBubbleContents to a BubbleDialogDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/content_setting_image_view.cc

Issue 1870533002: Convert ContentSettingBubbleContents to a BubbleDialogDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix mac views Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/location_bar/content_setting_image_view.h ('k') | chrome/browser/ui/views/location_bar/location_bar_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/location_bar/content_setting_image_view.cc

diff --git a/chrome/browser/ui/views/location_bar/content_setting_image_view.cc b/chrome/browser/ui/views/location_bar/content_setting_image_view.cc

index fc23d2ea00520ae84f3af7777a82308fe9722c31..f1a33e4891c4148bf2c4a0e5c2bf33621c8be4d0 100644

--- a/chrome/browser/ui/views/location_bar/content_setting_image_view.cc

+++ b/chrome/browser/ui/views/location_bar/content_setting_image_view.cc

@@ -273,7 +273,7 @@ void ContentSettingImageView::OnClick() {

web_contents, parent_->profile()),

web_contents, this, views::BubbleBorder::TOP_RIGHT);

views::Widget* bubble_widget =

- parent_->delegate()->CreateViewsBubble(bubble_view_);

+ views::BubbleDialogDelegateView::CreateBubble(bubble_view_);

bubble_widget->AddObserver(this);

// This is triggered by an input event. If the user clicks the icon while

// it's not animating, the icon will be placed in an active state, so the