Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 1866403006: Revert of AppListController refactoring part 3: Switching over to use AppListShower in Ash. (Closed)

Created:
4 years, 8 months ago by mfomitchev
Modified:
4 years, 8 months ago
Reviewers:
xiyuan, sky
CC:
chromium-reviews, kalyank, sadrul, Matt Giuca, tapted, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@mus_chrome_delegates_ash_impl
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of AppListController refactoring part 3: Switching over to use AppListShower in Ash. (patchset #4 id:60001 of https://codereview.chromium.org/1861013004/ ) Reason for revert: crrev.com/1856943003 was reverted, so this needs to be reverted as well. Original issue's description: > AppListController refactoring part 3: Switching over to use AppListShower in Ash. > > Part 1 of the refactoring: https://crrev.com/1830293002 > Part 2 of the refactoring: https://crrev.com/1856943003 > Design doc: https://docs.google.com/document/d/1M9vqTTuprMssRXs8UIVaFjQUq3lUxSzwrWoPjPvca6Q/edit?ts=56d0e9f0#heading=h.b2znwtuxd2x2 > > This CL makes Ash use app_list::AppListShowerImpl + ash::AppListShowerDelegate > tandem instead of ash::AppListController. AppListShower is owned by > AppListServiceAsh, and Ash goes to AppListServiceAsh (through > ChromeShellDelegate) when it needs to hide or show the app list. > > BUG=557408 > > Committed: https://crrev.com/2b8b5cae9e892e575f6dcff36993f5a0694fa33b > Cr-Commit-Position: refs/heads/master@{#386136} TBR=xiyuan@chromium.org,sky@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=557408 Committed: https://crrev.com/cabf63a7018f899d31f7f88cb2167c6b3fe5119a Cr-Commit-Position: refs/heads/master@{#386184}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1121 lines, -348 lines) Patch
M ash/ash.gyp View 4 chunks +8 lines, -1 line 0 comments Download
M ash/mus/shell_delegate_mus.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/mus/shell_delegate_mus.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell.h View 3 chunks +8 lines, -1 line 0 comments Download
M ash/shell.cc View 5 chunks +25 lines, -5 lines 0 comments Download
M ash/shell/shell_delegate_impl.h View 3 chunks +2 lines, -9 lines 0 comments Download
M ash/shell/shell_delegate_impl.cc View 4 chunks +5 lines, -32 lines 0 comments Download
M ash/shell_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
A ash/test/app_list_controller_test_api.h View 1 chunk +47 lines, -0 lines 0 comments Download
A ash/test/app_list_controller_test_api.cc View 1 chunk +40 lines, -0 lines 0 comments Download
M ash/test/shell_test_api.h View 2 chunks +2 lines, -5 lines 0 comments Download
M ash/test/shell_test_api.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M ash/test/test_shell_delegate.h View 4 chunks +2 lines, -13 lines 0 comments Download
M ash/test/test_shell_delegate.cc View 4 chunks +7 lines, -34 lines 0 comments Download
A ash/wm/app_list_controller.h View 1 chunk +153 lines, -0 lines 0 comments Download
A ash/wm/app_list_controller.cc View 1 chunk +557 lines, -0 lines 0 comments Download
A ash/wm/app_list_controller_unittest.cc View 1 chunk +192 lines, -0 lines 0 comments Download
M chrome/browser/apps/custom_launcher_page_browsertest_views.cc View 3 chunks +4 lines, -9 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_service_views_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/app_list/app_list_controller_ash.h View 2 chunks +1 line, -8 lines 0 comments Download
M chrome/browser/ui/ash/app_list/app_list_controller_ash.cc View 2 chunks +11 lines, -9 lines 0 comments Download
M chrome/browser/ui/ash/app_list/app_list_service_ash.h View 3 chunks +1 line, -13 lines 0 comments Download
M chrome/browser/ui/ash/app_list/app_list_service_ash.cc View 6 chunks +31 lines, -65 lines 0 comments Download
D chrome/browser/ui/ash/app_list/test/app_list_service_ash_test_api.h View 1 chunk +0 lines, -40 lines 0 comments Download
D chrome/browser/ui/ash/app_list/test/app_list_service_ash_test_api.cc View 1 chunk +0 lines, -45 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc View 7 chunks +12 lines, -8 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +0 lines, -14 lines 0 comments Download
M chrome/test/BUILD.gn View 2 chunks +0 lines, -21 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
mfomitchev
Created Revert of AppListController refactoring part 3: Switching over to use AppListShower in Ash.
4 years, 8 months ago (2016-04-08 20:14:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1866403006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1866403006/1
4 years, 8 months ago (2016-04-08 20:14:24 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-08 20:15:18 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/cabf63a7018f899d31f7f88cb2167c6b3fe5119a Cr-Commit-Position: refs/heads/master@{#386184}
4 years, 8 months ago (2016-04-08 20:16:51 UTC) #5
mfomitchev
4 years, 8 months ago (2016-04-09 00:03:38 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1874063002/ by mfomitchev@chromium.org.

The reason for reverting is: Relanding - this wasn't the CL that was causing the
problem
.

Powered by Google App Engine
This is Rietveld 408576698