ash/shell_delegate.h - Issue 1866403006: Revert of AppListController refactoring part 3: Switching over to use AppListShower in Ash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/shell_delegate.h

Issue 1866403006: Revert of AppListController refactoring part 3: Switching over to use AppListShower in Ash. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mus_chrome_delegates_ash_impl

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/shell_delegate.h

diff --git a/ash/shell_delegate.h b/ash/shell_delegate.h

index 922462900a1c569a59da7d14f451e670be510f80..4a17a7692f25a909f35dc1d87996d2c3a6ee5d16 100644

--- a/ash/shell_delegate.h

+++ b/ash/shell_delegate.h

@@ -15,7 +15,6 @@

class GURL;

namespace app_list {

-class AppListShower;

class AppListViewDelegate;

}

@@ -113,8 +112,9 @@

// Opens the |url| in a new browser tab.

virtual void OpenUrl(const GURL& url) = 0;

- // Get the AppListShower. Ownership stays with Chrome.

- virtual app_list::AppListShower* GetAppListShower() = 0;

+ // Get the AppListViewDelegate, creating one if it does not yet exist.

+ // Ownership stays with Chrome's AppListService, or the ShellDelegate.

+ virtual app_list::AppListViewDelegate* GetAppListViewDelegate() = 0;

// Creates a new ShelfDelegate. Shell takes ownership of the returned

// value.

« no previous file with comments | « ash/shell/shell_delegate_impl.cc ('k') | ash/test/app_list_controller_test_api.h » ('j') | no next file with comments »