DescriptionReland of AppListController refactoring part 3: Switching over to use AppListShower in Ash. (patchset #1 id:1 of https://codereview.chromium.org/1866403006/ )
Reason for revert:
Relanding - this wasn't the CL that was causing the problem
Original issue's description:
> Revert of AppListController refactoring part 3: Switching over to use AppListShower in Ash. (patchset #4 id:60001 of https://codereview.chromium.org/1861013004/ )
>
> Reason for revert:
> crrev.com/1856943003 was reverted, so this needs to be reverted as well.
>
> Original issue's description:
> > AppListController refactoring part 3: Switching over to use AppListShower in Ash.
> >
> > Part 1 of the refactoring: https://crrev.com/1830293002
> > Part 2 of the refactoring: https://crrev.com/1856943003
> > Design doc: https://docs.google.com/document/d/1M9vqTTuprMssRXs8UIVaFjQUq3lUxSzwrWoPjPvca6Q/edit?ts=56d0e9f0#heading=h.b2znwtuxd2x2
> >
> > This CL makes Ash use app_list::AppListShowerImpl + ash::AppListShowerDelegate
> > tandem instead of ash::AppListController. AppListShower is owned by
> > AppListServiceAsh, and Ash goes to AppListServiceAsh (through
> > ChromeShellDelegate) when it needs to hide or show the app list.
> >
> > BUG=557408
> >
> > Committed: https://crrev.com/2b8b5cae9e892e575f6dcff36993f5a0694fa33b
> > Cr-Commit-Position: refs/heads/master@{#386136}
>
> TBR=xiyuan@chromium.org,sky@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=557408
>
> Committed: https://crrev.com/cabf63a7018f899d31f7f88cb2167c6b3fe5119a
> Cr-Commit-Position: refs/heads/master@{#386184}
TBR=xiyuan@chromium.org,sky@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
BUG=557408
Committed: https://crrev.com/493ed60266b5c11b72c933ab304185727db80740
Cr-Commit-Position: refs/heads/master@{#386263}
Patch Set 1 #Messages
Total messages: 8 (4 generated)
|