Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Issue 1859293002: [DevTools] Move Console to v8_inspector (Closed)

Created:
4 years, 8 months ago by kozy
Modified:
4 years, 8 months ago
CC:
apavlov+blink_chromium.org, blink-reviews, blink-reviews-bindings_chromium.org, blink-worker-reviews_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, falken, haraken, horo+watch_chromium.org, kinuko+worker_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Move Console to v8_inspector This is a first patch in the effort of moving console to v8_inspector: - move Console object; - move ConsoleMessage; - move ConsoleMessageStorage. The benefits are: - moves the last v8-related inspector aspect to v8_inspector; - simplifies bindings between console, profiler and timeline; - reduces console API for the embedder, which mostly uses it as a log storage. As a side effect, this patch makes Console object functions automatically bound to Console: var log = console.log; log(42); BUG=167911, 580337 R=dgozman@chromium.org,jochen@chromium.org Committed: https://crrev.com/807ec9550e8a31517966636e6a5b506474ab4ea9 Cr-Commit-Position: refs/heads/master@{#388788}

Patch Set 1 #

Total comments: 8

Patch Set 2 : PoC #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 36

Patch Set 5 : #

Patch Set 6 : added missing tests #

Total comments: 44

Patch Set 7 : #

Patch Set 8 : #

Total comments: 32

Patch Set 9 : #

Patch Set 10 : #

Patch Set 11 : #

Patch Set 12 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+793 lines, -1168 lines) Patch
M third_party/WebKit/LayoutTests/fast/workers/worker-console-log.html View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/workers/worker-console-log-expected.txt View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/worklet/webexposed/global-interface-listing-paint-worklet-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/console/console-deprecated-methods.html View 1 2 3 4 5 6 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/console/console-deprecated-methods-expected.txt View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/inspector-protocol/console/console-memory-setter-in-strict-mode.html View 1 2 3 4 5 2 chunks +3 lines, -5 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/console/console-memory-setter-in-strict-mode-expected.txt View 1 2 3 4 5 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/cpu-profiler/console-profile.html View 1 2 3 4 5 6 7 8 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/cpu-profiler/console-profile-expected.txt View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/inspector/console/console-log-without-console.html View 1 chunk +9 lines, -12 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/console/console-log-without-console-expected.txt View 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 3 4 5 6 7 8 9 10 3 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 2 3 4 5 6 7 8 9 10 3 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt View 1 2 3 4 5 6 7 8 9 10 3 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 2 3 4 5 6 7 8 9 10 11 7 chunks +0 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/dom/AddConsoleMessageTask.h View 1 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/core/frame/Console.h View 1 2 3 4 5 6 1 chunk +0 lines, -64 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Console.cpp View 1 1 chunk +0 lines, -77 lines 0 comments Download
D third_party/WebKit/Source/core/frame/Console.idl View 1 1 chunk +0 lines, -39 lines 0 comments Download
M third_party/WebKit/Source/core/frame/ConsoleBase.h View 1 1 chunk +0 lines, -91 lines 0 comments Download
M third_party/WebKit/Source/core/frame/ConsoleBase.cpp View 1 1 chunk +0 lines, -230 lines 0 comments Download
D third_party/WebKit/Source/core/frame/ConsoleBase.idl View 1 2 3 4 5 6 1 chunk +0 lines, -63 lines 0 comments Download
D third_party/WebKit/Source/core/frame/ConsoleTypes.h View 1 1 chunk +0 lines, -55 lines 0 comments Download
M third_party/WebKit/Source/core/frame/DOMWindow.h View 1 2 3 4 5 6 7 8 9 10 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameConsole.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameConsole.cpp View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.h View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 1 2 3 4 5 6 7 8 9 10 11 4 chunks +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/frame/RemoteDOMWindow.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/RemoteDOMWindow.cpp View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/frame/SubresourceIntegrity.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/Window.idl View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/core/inspector/ConsoleAPITypes.h View 1 1 chunk +0 lines, -47 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/ConsoleMessage.h View 1 2 3 4 5 6 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorProfilerAgent.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorProfilerAgent.cpp View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/MainThreadDebugger.h View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp View 1 2 3 4 5 6 3 chunks +31 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/ThreadDebugger.h View 1 2 3 4 5 6 2 chunks +7 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp View 1 2 3 4 5 6 7 8 9 10 3 chunks +42 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp View 1 2 3 4 5 6 2 chunks +14 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/ChromeClient.h View 1 2 3 4 5 6 7 8 9 10 2 chunks +1 line, -2 lines 0 comments Download
D third_party/WebKit/Source/core/timing/ConsoleMemory.h View 1 1 chunk +0 lines, -31 lines 0 comments Download
D third_party/WebKit/Source/core/timing/ConsoleMemory.cpp View 1 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/WebKit/Source/core/timing/ConsoleMemory.idl View 1 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/Source/core/workers/WorkerConsole.h View 1 2 3 4 5 6 1 chunk +0 lines, -64 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerConsole.cpp View 1 1 chunk +0 lines, -69 lines 0 comments Download
D third_party/WebKit/Source/core/workers/WorkerConsole.idl View 1 1 chunk +0 lines, -38 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerGlobalScope.h View 1 2 3 4 5 6 3 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerGlobalScope.idl View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerReportingProxy.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp View 1 2 3 4 5 6 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/modules.gypi View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/websockets/DOMWebSocketTest.cpp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannelTest.cpp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/websockets/WebSocketChannel.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/worklet/WorkletConsole.h View 1 1 chunk +0 lines, -41 lines 0 comments Download
M third_party/WebKit/Source/modules/worklet/WorkletConsole.cpp View 1 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/WebKit/Source/modules/worklet/WorkletConsole.idl View 1 1 chunk +0 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.h View 1 2 3 4 5 6 3 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.cpp View 1 2 3 4 5 6 3 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.idl View 1 2 3 4 5 6 7 8 1 chunk +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/String16WTF.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InspectedContext.h View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InspectedContext.cpp View 1 2 3 4 5 6 7 8 2 chunks +10 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/v8_inspector/V8Console.h View 1 2 3 4 5 6 1 chunk +51 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp View 1 2 3 4 5 6 7 8 9 1 chunk +482 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h View 1 2 3 4 5 6 7 8 9 10 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp View 1 2 3 4 5 6 7 8 9 10 1 chunk +13 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.h View 1 2 3 4 2 chunks +4 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/platform/v8_inspector/public/ConsoleAPITypes.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/v8_inspector/public/ConsoleTypes.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8ContextInfo.h View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h View 1 2 3 4 5 6 2 chunks +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8ProfilerAgent.h View 1 2 3 4 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebPepperSocketImpl.cpp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 38 (15 generated)
kozy
Dmitry, please take a look!
4 years, 8 months ago (2016-04-06 01:24:24 UTC) #2
dgozman
https://codereview.chromium.org/1859293002/diff/1/third_party/WebKit/LayoutTests/inspector/console/console-log-without-console-expected.txt File third_party/WebKit/LayoutTests/inspector/console/console-log-without-console-expected.txt (right): https://codereview.chromium.org/1859293002/diff/1/third_party/WebKit/LayoutTests/inspector/console/console-log-without-console-expected.txt#newcode9 third_party/WebKit/LayoutTests/inspector/console/console-log-without-console-expected.txt:9: console-log-without-console.html:11 3(anonymous function) @ console-log-without-console.html:11 Why two locations here? ...
4 years, 8 months ago (2016-04-06 15:51:33 UTC) #3
kozy
Addressed comments. https://codereview.chromium.org/1859293002/diff/1/third_party/WebKit/LayoutTests/inspector/console/console-log-without-console-expected.txt File third_party/WebKit/LayoutTests/inspector/console/console-log-without-console-expected.txt (right): https://codereview.chromium.org/1859293002/diff/1/third_party/WebKit/LayoutTests/inspector/console/console-log-without-console-expected.txt#newcode9 third_party/WebKit/LayoutTests/inspector/console/console-log-without-console-expected.txt:9: console-log-without-console.html:11 3(anonymous function) @ console-log-without-console.html:11 On 2016/04/06 ...
4 years, 8 months ago (2016-04-06 17:45:21 UTC) #4
kozy
I've uploaded proof of concept. All tests are passed. Performance is the same as previous ...
4 years, 8 months ago (2016-04-07 00:56:39 UTC) #6
kozy
Ready for review. Please take a look!
4 years, 8 months ago (2016-04-07 23:39:34 UTC) #7
dgozman
General direction is good. Let's make sure we have prototype with methods, similar to Firefox. ...
4 years, 8 months ago (2016-04-08 18:18:46 UTC) #9
kozy
All done. Please take a look! https://codereview.chromium.org/1859293002/diff/80001/third_party/WebKit/LayoutTests/fast/dom/Window/window-lookup-precedence-expected.txt File third_party/WebKit/LayoutTests/fast/dom/Window/window-lookup-precedence-expected.txt (right): https://codereview.chromium.org/1859293002/diff/80001/third_party/WebKit/LayoutTests/fast/dom/Window/window-lookup-precedence-expected.txt#newcode307 third_party/WebKit/LayoutTests/fast/dom/Window/window-lookup-precedence-expected.txt:307: PASS win['console'] == ...
4 years, 8 months ago (2016-04-08 23:56:51 UTC) #10
dgozman
https://codereview.chromium.org/1859293002/diff/120001/third_party/WebKit/LayoutTests/inspector/tracing/timeline-mark-timeline-expected.txt File third_party/WebKit/LayoutTests/inspector/tracing/timeline-mark-timeline-expected.txt (left): https://codereview.chromium.org/1859293002/diff/120001/third_party/WebKit/LayoutTests/inspector/tracing/timeline-mark-timeline-expected.txt#oldcode4 third_party/WebKit/LayoutTests/inspector/tracing/timeline-mark-timeline-expected.txt:4: TimeStamp Properties: Let's not introduce behavior changes in this ...
4 years, 8 months ago (2016-04-12 03:32:16 UTC) #11
kozy
All done. Dmitry, please take a look! https://codereview.chromium.org/1859293002/diff/120001/third_party/WebKit/LayoutTests/inspector/tracing/timeline-mark-timeline-expected.txt File third_party/WebKit/LayoutTests/inspector/tracing/timeline-mark-timeline-expected.txt (left): https://codereview.chromium.org/1859293002/diff/120001/third_party/WebKit/LayoutTests/inspector/tracing/timeline-mark-timeline-expected.txt#oldcode4 third_party/WebKit/LayoutTests/inspector/tracing/timeline-mark-timeline-expected.txt:4: TimeStamp Properties: ...
4 years, 8 months ago (2016-04-12 21:58:32 UTC) #13
dgozman
https://codereview.chromium.org/1859293002/diff/180001/third_party/WebKit/Source/core/frame/ConsoleBase.idl File third_party/WebKit/Source/core/frame/ConsoleBase.idl (left): https://codereview.chromium.org/1859293002/diff/180001/third_party/WebKit/Source/core/frame/ConsoleBase.idl#oldcode49 third_party/WebKit/Source/core/frame/ConsoleBase.idl:49: void profile(optional DOMString title = null); Let's make sure ...
4 years, 8 months ago (2016-04-12 23:21:58 UTC) #14
kozy
All done. ptal! https://codereview.chromium.org/1859293002/diff/180001/third_party/WebKit/Source/core/frame/ConsoleBase.idl File third_party/WebKit/Source/core/frame/ConsoleBase.idl (left): https://codereview.chromium.org/1859293002/diff/180001/third_party/WebKit/Source/core/frame/ConsoleBase.idl#oldcode49 third_party/WebKit/Source/core/frame/ConsoleBase.idl:49: void profile(optional DOMString title = null); ...
4 years, 8 months ago (2016-04-12 23:34:26 UTC) #15
dgozman
This looks good to me. Pavel, please take a look as well.
4 years, 8 months ago (2016-04-12 23:58:58 UTC) #17
kozy
Rebased, please take a look.
4 years, 8 months ago (2016-04-18 23:44:23 UTC) #18
kozy
ping?
4 years, 8 months ago (2016-04-20 19:18:12 UTC) #19
dgozman
lgtm
4 years, 8 months ago (2016-04-20 21:40:52 UTC) #20
pfeldman
lgtm
4 years, 8 months ago (2016-04-20 23:43:19 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1859293002/250001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1859293002/250001
4 years, 8 months ago (2016-04-21 00:05:45 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/171124)
4 years, 8 months ago (2016-04-21 00:18:43 UTC) #28
kozy
@jochen, please take a look. I need owner lgtm for following webexposed tests: third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt ...
4 years, 8 months ago (2016-04-21 00:21:42 UTC) #31
jochen (gone - plz use gerrit)
lgtm
4 years, 8 months ago (2016-04-21 14:45:37 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1859293002/250001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1859293002/250001
4 years, 8 months ago (2016-04-21 15:27:12 UTC) #34
commit-bot: I haz the power
Committed patchset #12 (id:250001)
4 years, 8 months ago (2016-04-21 16:44:16 UTC) #36
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:35:16 UTC) #38
Message was sent while issue was closed.
Patchset 12 (id:??) landed as
https://crrev.com/807ec9550e8a31517966636e6a5b506474ab4ea9
Cr-Commit-Position: refs/heads/master@{#388788}

Powered by Google App Engine
This is Rietveld 408576698