Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Unified Diff: third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp

Issue 1859293002: [DevTools] Move Console to v8_inspector (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp
diff --git a/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp b/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp
index 7741cd4b52a922c6c8877be69ce3542b8b6bf331..fa682c463c2abd2ac37791d7417023056f7a4496 100644
--- a/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp
+++ b/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp
@@ -61,7 +61,7 @@ WorkerThreadDebugger::~WorkerThreadDebugger()
void WorkerThreadDebugger::contextCreated(v8::Local<v8::Context> context)
{
- debugger()->contextCreated(V8ContextInfo(context, workerContextGroupId, true, m_workerThread->workerGlobalScope()->url().getString(), "", ""));
+ debugger()->contextCreated(V8ContextInfo(context, workerContextGroupId, true, m_workerThread->workerGlobalScope()->url().getString(), "", "", false));
}
void WorkerThreadDebugger::contextWillBeDestroyed(v8::Local<v8::Context> context)
@@ -100,4 +100,17 @@ int WorkerThreadDebugger::ensureDefaultContextInGroup(int contextGroupId)
return V8Debugger::contextId(scriptState->context());
}
+void WorkerThreadDebugger::reportMessageToConsole(v8::Local<v8::Context> context, ConsoleMessage* message)
+{
+ ExecutionContext* executionContext = toExecutionContext(context);
+ ASSERT(executionContext->isWorkerGlobalScope());
+ executionContext->addConsoleMessage(message);
+}
+
+v8::MaybeLocal<v8::Value> WorkerThreadDebugger::memoryInfo(v8::Isolate*, v8::Local<v8::Context>, v8::Local<v8::Object>)
+{
+ ASSERT_NOT_REACHED();
+ return v8::MaybeLocal<v8::Value>();
+}
+
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h ('k') | third_party/WebKit/Source/core/page/ChromeClient.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698