third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.h - Issue 1859293002: [DevTools] Move Console to v8_inspector

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.h

Issue 1859293002: [DevTools] Move Console to v8_inspector (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h ('k') | third_party/WebKit/Source/platform/v8_inspector/public/ConsoleAPITypes.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.h b/third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.h

index 4766a9d51f9c0bf2c09ff196b4068f64f296b444..612621b08b6b9f4a2f3929d6ed8b6b9a95791dfd 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.h

@@ -25,6 +25,8 @@ public:

explicit V8ProfilerAgentImpl(V8InspectorSessionImpl*);

~V8ProfilerAgentImpl() override;

+ bool enabled() const { return m_enabled; }

void setInspectorState(protocol::DictionaryValue* state) override { m_state = state; }

void setFrontend(protocol::Frontend::Profiler* frontend) override { m_frontend = frontend; }

void clearFrontend() override;

@@ -36,8 +38,8 @@ public:

void start(ErrorString*) override;

void stop(ErrorString*, OwnPtr<protocol::Profiler::CPUProfile>*) override;

- void consoleProfile(const String16& title) override;

- void consoleProfileEnd(const String16& title) override;

+ void consoleProfile(const String16& title);

+ void consoleProfileEnd(const String16& title);

void idleStarted() override;

void idleFinished() override;