third_party/WebKit/Source/core/inspector/MainThreadDebugger.h - Issue 1859293002: [DevTools] Move Console to v8_inspector

Side by Side Diff: third_party/WebKit/Source/core/inspector/MainThreadDebugger.h

Issue 1859293002: [DevTools] Move Console to v8_inspector (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/inspector/tracing/timeline-timer-fired-from-eval-call-site-expected.txt ('K') | « third_party/WebKit/Source/core/inspector/InspectorInstrumentation.h ('k') | third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp » ('j') | third_party/WebKit/Source/core/inspector/ThreadDebugger.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (c) 2011 Google Inc. All rights reserved.	2 * Copyright (c) 2011 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 50 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
61 static MainThreadDebugger* instance();	61 static MainThreadDebugger* instance();

62 static void interruptMainThreadAndRun(PassOwnPtr<InspectorTaskRunner::Task>) ;	62 static void interruptMainThreadAndRun(PassOwnPtr<InspectorTaskRunner::Task>) ;

63	63

64 InspectorTaskRunner* taskRunner() const { return m_taskRunner.get(); }	64 InspectorTaskRunner* taskRunner() const { return m_taskRunner.get(); }

65 bool isWorker() override { return false; }	65 bool isWorker() override { return false; }

66 void setClientMessageLoop(PassOwnPtr<ClientMessageLoop>);	66 void setClientMessageLoop(PassOwnPtr<ClientMessageLoop>);

67 int contextGroupId(LocalFrame*);	67 int contextGroupId(LocalFrame*);

68 void contextCreated(ScriptState, LocalFrame, SecurityOrigin*);	68 void contextCreated(ScriptState, LocalFrame, SecurityOrigin*);

69 void contextWillBeDestroyed(ScriptState*);	69 void contextWillBeDestroyed(ScriptState*);

70	70

	71 bool hasMemoryOnConsole(v8::Local<v8::Context>) override;
	dgozman 2016/04/08 18:18:46 This bit should be a part of V8ContextInfo, which This bit should be a part of V8ContextInfo, which embedded reports on context creation. kozy 2016/04/08 23:56:50 Done. Show quoted text On 2016/04/08 18:18:46, dgozman wrote: > This bit should be a part of V8ContextInfo, which embedded reports on context > creation. Done.
	72 v8::MaybeLocal<v8::Value> memoryInfo(v8::Isolate*, v8::Local<v8::Context>, v 8::Local<v8::Object> creationContext) override;
	dgozman 2016/04/08 18:18:46 We can probably do this directly by asking V8. We can probably do this directly by asking V8. kozy 2016/04/08 23:56:50 blink implementation is using a lot of core relate Show quoted text On 2016/04/08 18:18:46, dgozman wrote: > We can probably do this directly by asking V8. blink implementation is using a lot of core related stuff like UserMetrics, probably we can move MemoryInfo to v8_inspector later.
	73 protected:

	74 void reportMessageToConsole(v8::Local<v8::Context>, ConsoleMessage*);
	dgozman 2016/04/08 18:18:46 override? override? kozy 2016/04/08 23:56:50 Done. Show quoted text On 2016/04/08 18:18:46, dgozman wrote: > override? Done.
	75

71 private:	76 private:

72 // V8DebuggerClient implementation.	77 // V8DebuggerClient implementation.

73 void runMessageLoopOnPause(int contextGroupId) override;	78 void runMessageLoopOnPause(int contextGroupId) override;

74 void quitMessageLoopOnPause() override;	79 void quitMessageLoopOnPause() override;

75 void muteWarningsAndDeprecations() override;	80 void muteWarningsAndDeprecations() override;

76 void unmuteWarningsAndDeprecations() override;	81 void unmuteWarningsAndDeprecations() override;

77 void muteConsole() override;	82 void muteConsole() override;

78 void unmuteConsole() override;	83 void unmuteConsole() override;

79 bool callingContextCanAccessContext(v8::Local<v8::Context> calling, v8::Loca l<v8::Context> target) override;	84 bool callingContextCanAccessContext(v8::Local<v8::Context> calling, v8::Loca l<v8::Context> target) override;

80	85

81 OwnPtr<ClientMessageLoop> m_clientMessageLoop;	86 OwnPtr<ClientMessageLoop> m_clientMessageLoop;

82 OwnPtr<InspectorTaskRunner> m_taskRunner;	87 OwnPtr<InspectorTaskRunner> m_taskRunner;

83	88

84 static MainThreadDebugger* s_instance;	89 static MainThreadDebugger* s_instance;

85 };	90 };

86	91

87 } // namespace blink	92 } // namespace blink

88	93

89	94

90 #endif // MainThreadDebugger_h	95 #endif // MainThreadDebugger_h

OLD	NEW