Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Unified Diff: third_party/WebKit/Source/core/inspector/ThreadDebugger.h

Issue 1859293002: [DevTools] Move Console to v8_inspector (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/ThreadDebugger.h
diff --git a/third_party/WebKit/Source/core/inspector/ThreadDebugger.h b/third_party/WebKit/Source/core/inspector/ThreadDebugger.h
index 9fb7632c0b152504152d2b219019d5f0282029ef..9ccbca21f1c2b41479b2dff8121c275c6c14f7d7 100644
--- a/third_party/WebKit/Source/core/inspector/ThreadDebugger.h
+++ b/third_party/WebKit/Source/core/inspector/ThreadDebugger.h
@@ -14,6 +14,7 @@
namespace blink {
+class ConsoleMessage;
class WorkerThread;
class CORE_EXPORT ThreadDebugger : public V8DebuggerClient {
@@ -28,11 +29,16 @@ public:
bool formatAccessorsAsProperties(v8::Local<v8::Value>) override;
bool isExecutionAllowed() override;
double currentTimeMS() override;
+ void reportMessageToConsole(v8::Local<v8::Context>, MessageType, MessageLevel, const String16& message, const v8::FunctionCallbackInfo<v8::Value>* arguments, unsigned skipArgumentCount, int maxStackSize) final;
+ void consoleTime(const String16& title) override;
+ void consoleTimeEnd(const String16& title) override;
+ void consoleTimeStamp(const String16& title) override;
V8Debugger* debugger() const { return m_debugger.get(); }
virtual bool isWorker() { return true; }
-
protected:
+ virtual void reportMessageToConsole(v8::Local<v8::Context>, ConsoleMessage*) = 0;
+
v8::Isolate* m_isolate;
OwnPtr<V8Debugger> m_debugger;
};

Powered by Google App Engine
This is Rietveld 408576698