Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 1854993002: [Extensions] Remove linked_ptr entirely from extensions generated code (Closed)

Created:
4 years, 8 months ago by Devlin
Modified:
4 years, 8 months ago
Reviewers:
lazyboy, Ilya Sherman
CC:
chromium-reviews, extensions-reviews_chromium.org, vabr+watchlistpasswordmanager_chromium.org, mlamouri+watch-content_chromium.org, rouslan+autofill_chromium.org, browser-components-watch_chromium.org, jam, jdonnelly+autofillwatch_chromium.org, bondd+autofillwatch_chromium.org, rginda+watch_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, estade+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, chromium-apps-reviews_chromium.org, gcasto+watchlist_chromium.org, vabr+watchlistautofill_chromium.org, davemoore+watch_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Remove linked_ptr entirely from extensions generated code After the work to implement movable types in extensions generated code (completed in r384773), we now only use linked_ptrs to store base::Values in containers. Luckily, we don't need to - convert these to scoped_ptrs and eliminate all traces of linked_ptrs from extensions generated code. BUG=595949 TBR=isherman@chromium.org (autofill IWYU fix) Committed: https://crrev.com/3d8ce9c0d399ff8897632ce7469c56f2e2487234 Cr-Commit-Position: refs/heads/master@{#385005}

Patch Set 1 : #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -102 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/job_event_router.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc View 6 chunks +13 lines, -19 lines 0 comments Download
M chrome/browser/extensions/api/developer_private/developer_private_mangle.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/autofill/content/renderer/password_autofill_agent.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/api/declarative/declarative_rule.h View 4 chunks +4 lines, -4 lines 0 comments Download
M extensions/browser/api/declarative/declarative_rule_unittest.cc View 7 chunks +16 lines, -25 lines 0 comments Download
M extensions/browser/api/declarative/rules_registry.h View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/api/declarative_webrequest/webrequest_condition_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M extensions/browser/api/system_storage/system_storage_apitest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/common/api/declarative/declarative_manifest_data.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/json_schema_compiler/cpp_type_generator.py View 2 chunks +6 lines, -11 lines 0 comments Download
M tools/json_schema_compiler/h_generator.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/json_schema_compiler/util.h View 6 chunks +11 lines, -17 lines 0 comments Download
M tools/json_schema_compiler/util.cc View 3 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
Devlin
Istiaque, mind taking a look? (Note: the added #includes are for IWYU errors)
4 years, 8 months ago (2016-04-04 16:43:50 UTC) #4
lazyboy
lgtm
4 years, 8 months ago (2016-04-04 18:36:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1854993002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1854993002/40001
4 years, 8 months ago (2016-04-04 20:43:34 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/164297)
4 years, 8 months ago (2016-04-04 20:55:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1854993002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1854993002/40001
4 years, 8 months ago (2016-04-04 21:03:11 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 8 months ago (2016-04-04 21:14:28 UTC) #16
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 21:15:34 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3d8ce9c0d399ff8897632ce7469c56f2e2487234
Cr-Commit-Position: refs/heads/master@{#385005}

Powered by Google App Engine
This is Rietveld 408576698