Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5759)

Unified Diff: chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc

Issue 1854993002: [Extensions] Remove linked_ptr entirely from extensions generated code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc
diff --git a/chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc b/chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc
index f2e1134d356195c94a6271444be02daa35554e1b..6545895c6c2a182911f8d0513f0d507be0e2cf3b 100644
--- a/chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc
+++ b/chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc
@@ -54,7 +54,7 @@ scoped_ptr<WebRequestActionSet> CreateSetOfActions(const char* json) {
++it) {
const base::DictionaryValue* dict;
CHECK((*it)->GetAsDictionary(&dict));
- actions.push_back(linked_ptr<base::Value>(dict->DeepCopy()));
+ actions.push_back(dict->CreateDeepCopy());
}
std::string error;
@@ -242,7 +242,7 @@ TEST(WebRequestActionTest, CreateActionSet) {
incorrect_action.SetString(keys::kInstanceTypeKey, kUnknownActionType);
// Test success.
- input.push_back(linked_ptr<base::Value>(correct_action.DeepCopy()));
+ input.push_back(correct_action.CreateDeepCopy());
error.clear();
result = WebRequestActionSet::Create(NULL, NULL, input, &error, &bad_message);
EXPECT_TRUE(error.empty()) << error;
@@ -254,7 +254,7 @@ TEST(WebRequestActionTest, CreateActionSet) {
EXPECT_EQ(10, result->GetMinimumPriority());
// Test failure.
- input.push_back(linked_ptr<base::Value>(incorrect_action.DeepCopy()));
+ input.push_back(incorrect_action.CreateDeepCopy());
error.clear();
result = WebRequestActionSet::Create(NULL, NULL, input, &error, &bad_message);
EXPECT_NE("", error);

Powered by Google App Engine
This is Rietveld 408576698