extensions/browser/api/declarative_webrequest/webrequest_condition_unittest.cc - Issue 1854993002: [Extensions] Remove linked_ptr entirely from extensions generated code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/declarative_webrequest/webrequest_condition_unittest.cc

Issue 1854993002: [Extensions] Remove linked_ptr entirely from extensions generated code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/declarative/rules_registry.h ('k') | extensions/browser/api/system_storage/system_storage_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/declarative_webrequest/webrequest_condition_unittest.cc

diff --git a/extensions/browser/api/declarative_webrequest/webrequest_condition_unittest.cc b/extensions/browser/api/declarative_webrequest/webrequest_condition_unittest.cc

index 18d7f2bcc24ec0757d3523cc7f4ca216dd79a32b..0de50310766516df74125755d6da0a69139d2836 100644

--- a/extensions/browser/api/declarative_webrequest/webrequest_condition_unittest.cc

+++ b/extensions/browser/api/declarative_webrequest/webrequest_condition_unittest.cc

@@ -254,15 +254,15 @@ TEST(WebRequestConditionTest, CreateConditionSet) {

URLMatcher matcher;

WebRequestConditionSet::Values conditions;

- conditions.push_back(linked_ptr<base::Value>(base::test::ParseJson(

+ conditions.push_back(base::test::ParseJson(

"{ \n"

" \"instanceType\": \"declarativeWebRequest.RequestMatcher\", \n"

" \"url\": { \n"

" \"hostSuffix\": \"example.com\", \n"

" \"schemes\": [\"http\"], \n"

" }, \n"

- "}").release()));

- conditions.push_back(linked_ptr<base::Value>(base::test::ParseJson(

+ "}"));

+ conditions.push_back(base::test::ParseJson(

"{ \n"

" \"instanceType\": \"declarativeWebRequest.RequestMatcher\", \n"

" \"url\": { \n"

@@ -270,7 +270,7 @@ TEST(WebRequestConditionTest, CreateConditionSet) {

" \"hostPrefix\": \"www\", \n"

" \"schemes\": [\"https\"], \n"

" }, \n"

- "}").release()));

+ "}"));

// Test insertion

std::string error;

@@ -323,14 +323,14 @@ TEST(WebRequestConditionTest, TestPortFilter) {

URLMatcher matcher;

WebRequestConditionSet::Values conditions;

- conditions.push_back(linked_ptr<base::Value>(base::test::ParseJson(

+ conditions.push_back(base::test::ParseJson(

"{ \n"

" \"instanceType\": \"declarativeWebRequest.RequestMatcher\", \n"

" \"url\": { \n"

" \"ports\": [80, [1000, 1010]], \n" // Allow 80;1000-1010.

" \"hostSuffix\": \"example.com\", \n"

" }, \n"

- "}").release()));

+ "}"));

// Test insertion

std::string error;