extensions/common/api/declarative/declarative_manifest_data.cc - Issue 1854993002: [Extensions] Remove linked_ptr entirely from extensions generated code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/api/declarative/declarative_manifest_data.cc

Issue 1854993002: [Extensions] Remove linked_ptr entirely from extensions generated code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/system_storage/system_storage_apitest.cc ('k') | tools/json_schema_compiler/cpp_type_generator.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/api/declarative/declarative_manifest_data.cc

diff --git a/extensions/common/api/declarative/declarative_manifest_data.cc b/extensions/common/api/declarative/declarative_manifest_data.cc

index 44f23bbf2e2165260540d1d530ed1e0584ab348b..77460f1a8d5267319c21bb1c0cd9bc2eaacce9a2 100644

--- a/extensions/common/api/declarative/declarative_manifest_data.cc

+++ b/extensions/common/api/declarative/declarative_manifest_data.cc

@@ -61,8 +61,8 @@ class ErrorBuilder {

bool ConvertManifestRule(const linked_ptr<DeclarativeManifestData::Rule>& rule,

ErrorBuilder* error_builder) {

auto convert_list =

- [error_builder](std::vector<linked_ptr<base::Value>>& list) {

- for (const linked_ptr<base::Value>& value : list) {

+ [error_builder](std::vector<scoped_ptr<base::Value>>& list) {

+ for (const scoped_ptr<base::Value>& value : list) {

base::DictionaryValue* dictionary = nullptr;

if (!value->GetAsDictionary(&dictionary)) {

error_builder->Append("expected dictionary, got %s",