chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry.cc - Issue 1854993002: [Extensions] Remove linked_ptr entirely from extensions generated code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry.cc

Issue 1854993002: [Extensions] Remove linked_ptr entirely from extensions generated code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/file_manager/job_event_router.h ('k') | chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry.cc

diff --git a/chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry.cc b/chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry.cc

index a80fc25909fe5186c82afb2b75ad582e812ca51b..4b99dc0b6097b89412010207ee8840c608c1fd84 100644

--- a/chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry.cc

+++ b/chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry.cc

@@ -164,7 +164,7 @@ ChromeContentRulesRegistry::CreateRule(

const api::events::Rule& api_rule,

std::string* error) {

std::vector<scoped_ptr<const ContentCondition>> conditions;

- for (const linked_ptr<base::Value>& value : api_rule.conditions) {

+ for (const scoped_ptr<base::Value>& value : api_rule.conditions) {

conditions.push_back(

CreateContentCondition(extension, predicate_factories, *value, error));

if (!error->empty())

@@ -172,7 +172,7 @@ ChromeContentRulesRegistry::CreateRule(

}

std::vector<scoped_ptr<const ContentAction>> actions;

- for (const linked_ptr<base::Value>& value : api_rule.actions) {

+ for (const scoped_ptr<base::Value>& value : api_rule.actions) {

actions.push_back(ContentAction::Create(browser_context(), extension,

*value, error));

if (!error->empty())