Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: chrome/browser/extensions/api/developer_private/developer_private_mangle.cc

Issue 1854993002: [Extensions] Remove linked_ptr entirely from extensions generated code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/developer_private/developer_private_mangle.cc
diff --git a/chrome/browser/extensions/api/developer_private/developer_private_mangle.cc b/chrome/browser/extensions/api/developer_private/developer_private_mangle.cc
index 7f43b82aeb41fcfe7694669e0116b368b18dfa31..75d64f0a3cd2494e6843e46692647c04a9c41691 100644
--- a/chrome/browser/extensions/api/developer_private/developer_private_mangle.cc
+++ b/chrome/browser/extensions/api/developer_private/developer_private_mangle.cc
@@ -83,7 +83,7 @@ api::developer_private::ItemInfo MangleExtensionInfo(
scoped_ptr<base::DictionaryValue> value = error.ToValue();
value->SetInteger("type", static_cast<int>(ExtensionError::MANIFEST_ERROR));
value->SetInteger("level", static_cast<int>(logging::LOG_WARNING));
- result.manifest_errors.push_back(make_linked_ptr(value.release()));
+ result.manifest_errors.push_back(std::move(value));
}
for (const api::developer_private::RuntimeError& error :
info.runtime_errors) {
@@ -95,7 +95,7 @@ api::developer_private::ItemInfo MangleExtensionInfo(
else if (error.severity == api::developer_private::ERROR_LEVEL_ERROR)
severity = logging::LOG_ERROR;
value->SetInteger("level", static_cast<int>(severity));
- result.runtime_errors.push_back(make_linked_ptr(value.release()));
+ result.runtime_errors.push_back(std::move(value));
}
result.offline_enabled = info.offline_enabled;
for (const api::developer_private::ExtensionView& view : info.views) {

Powered by Google App Engine
This is Rietveld 408576698