Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1849463002: rename sk_gpu_test::GLContext to sk_gpu_test::GLTestContext (Closed)

Created:
4 years, 8 months ago by bsalomon
Modified:
4 years, 8 months ago
Reviewers:
jvanverth1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@move
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : few missed replaces #

Patch Set 3 : few more missed cases #

Patch Set 4 : return types to GLTestContext #

Patch Set 5 : share context param type #

Patch Set 6 : fix windows build #

Patch Set 7 : readd gpu.gypi #

Unified diffs Side-by-side diffs Delta from patch set Stats (+214 lines, -4510 lines) Patch
M bench/nanobench.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M dm/DM.cpp View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M samplecode/SampleApp.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M tests/EGLImageTest.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M tests/RectangleTextureTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/Test.h View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/TestTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/TextureStorageAllocator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/VisualBench/VisualBench.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/VisualBench/VisualBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/VisualBench/VisualStreamTimingModule.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/gpu/GrContextFactory.h View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download
M tools/gpu/GrContextFactory.cpp View 1 2 3 4 2 chunks +16 lines, -16 lines 0 comments Download
D tools/gpu/gl/GLContext.h View 1 chunk +0 lines, -141 lines 0 comments Download
D tools/gpu/gl/GLContext.cpp View 1 chunk +0 lines, -188 lines 0 comments Download
A + tools/gpu/gl/GLTestContext.h View 4 chunks +10 lines, -10 lines 0 comments Download
A + tools/gpu/gl/GLTestContext.cpp View 7 chunks +16 lines, -16 lines 0 comments Download
D tools/gpu/gl/angle/GLContext_angle.h View 1 chunk +0 lines, -30 lines 0 comments Download
D tools/gpu/gl/angle/GLContext_angle.cpp View 1 2 3 4 1 chunk +0 lines, -320 lines 0 comments Download
A + tools/gpu/gl/angle/GLTestContext_angle.h View 2 chunks +7 lines, -7 lines 0 comments Download
A + tools/gpu/gl/angle/GLTestContext_angle.cpp View 1 2 3 4 5 6 chunks +10 lines, -9 lines 0 comments Download
D tools/gpu/gl/command_buffer/GLContext_command_buffer.h View 1 chunk +0 lines, -68 lines 0 comments Download
D tools/gpu/gl/command_buffer/GLContext_command_buffer.cpp View 1 chunk +0 lines, -345 lines 0 comments Download
A + tools/gpu/gl/command_buffer/GLTestContext_command_buffer.h View 3 chunks +11 lines, -11 lines 0 comments Download
A + tools/gpu/gl/command_buffer/GLTestContext_command_buffer.cpp View 9 chunks +13 lines, -13 lines 0 comments Download
D tools/gpu/gl/debug/DebugGLContext.h View 1 chunk +0 lines, -17 lines 0 comments Download
D tools/gpu/gl/debug/DebugGLContext.cpp View 1 chunk +0 lines, -1256 lines 0 comments Download
A + tools/gpu/gl/debug/DebugGLTestContext.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + tools/gpu/gl/debug/DebugGLTestContext.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
D tools/gpu/gl/egl/CreatePlatformGLContext_egl.cpp View 1 chunk +0 lines, -337 lines 0 comments Download
A + tools/gpu/gl/egl/CreatePlatformGLTestContext_egl.cpp View 1 2 3 4 10 chunks +29 lines, -27 lines 0 comments Download
D tools/gpu/gl/glx/CreatePlatformGLContext_glx.cpp View 1 chunk +0 lines, -346 lines 0 comments Download
A + tools/gpu/gl/glx/CreatePlatformGLTestContext_glx.cpp View 1 2 3 4 5 chunks +14 lines, -13 lines 0 comments Download
D tools/gpu/gl/iOS/CreatePlatformGLContext_iOS.mm View 1 chunk +0 lines, -108 lines 0 comments Download
A + tools/gpu/gl/iOS/CreatePlatformGLTestContext_iOS.mm View 1 2 3 4 6 chunks +13 lines, -12 lines 0 comments Download
D tools/gpu/gl/mac/CreatePlatformGLContext_mac.cpp View 1 chunk +0 lines, -128 lines 0 comments Download
A + tools/gpu/gl/mac/CreatePlatformGLTestContext_mac.cpp View 1 2 3 4 5 chunks +13 lines, -12 lines 0 comments Download
D tools/gpu/gl/mesa/GLContext_mesa.h View 1 chunk +0 lines, -17 lines 0 comments Download
D tools/gpu/gl/mesa/GLContext_mesa.cpp View 1 chunk +0 lines, -151 lines 0 comments Download
A + tools/gpu/gl/mesa/GLTestContext_mesa.h View 1 chunk +4 lines, -4 lines 0 comments Download
A + tools/gpu/gl/mesa/GLTestContext_mesa.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
D tools/gpu/gl/null/NullGLContext.h View 1 chunk +0 lines, -17 lines 0 comments Download
D tools/gpu/gl/null/NullGLContext.cpp View 1 chunk +0 lines, -630 lines 0 comments Download
A + tools/gpu/gl/null/NullGLTestContext.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + tools/gpu/gl/null/NullGLTestContext.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
D tools/gpu/gl/win/CreatePlatformGLContext_win.cpp View 1 chunk +0 lines, -204 lines 0 comments Download
A + tools/gpu/gl/win/CreatePlatformGLTestContext_win.cpp View 1 2 3 4 7 chunks +14 lines, -13 lines 0 comments Download
M tools/kilobench/kilobench.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M tools/skiaserve/Request.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 28 (15 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1849463002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1849463002/20001
4 years, 8 months ago (2016-03-30 15:54:01 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1849463002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1849463002/40001
4 years, 8 months ago (2016-03-30 15:56:20 UTC) #5
bsalomon
This was mostly done mechanically, please don't spend too long on it! There are some ...
4 years, 8 months ago (2016-03-30 15:57:55 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_64-Release-Trybot/builds/1584)
4 years, 8 months ago (2016-03-30 15:58:11 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1849463002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1849463002/60001
4 years, 8 months ago (2016-03-30 16:01:18 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_64-Release-Trybot/builds/1585)
4 years, 8 months ago (2016-03-30 16:02:50 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1849463002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1849463002/80001
4 years, 8 months ago (2016-03-31 03:31:45 UTC) #15
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-31 03:42:16 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1849463002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1849463002/80001
4 years, 8 months ago (2016-03-31 17:06:23 UTC) #20
commit-bot: I haz the power
Committed patchset #5 (id:80001) as https://skia.googlesource.com/skia/+/4c7f0a16312c374eba4e8d5d46435ce9eb0b9971
4 years, 8 months ago (2016-03-31 17:07:28 UTC) #22
bsalomon
A revert of this CL (patchset #5 id:80001) has been created in https://codereview.chromium.org/1850543003/ by bsalomon@google.com. ...
4 years, 8 months ago (2016-03-31 17:22:10 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1849463002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1849463002/120001
4 years, 8 months ago (2016-03-31 17:40:18 UTC) #26
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 17:59:12 UTC) #28
Message was sent while issue was closed. 
Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/273c0f5e87397c40d22bb7e3ee078bb46a3f6860

Powered by Google App Engine
This is Rietveld 408576698