Re-enable all the windows warnings except 4267

Re-enable all the windows warnings except 4267

The code is changed or had been changed to no longer generate these
warnings. It is safe to re-enabled these warnings.

In this code change, we fixed some code which generates warnings 4018
(signed/unsigned mismatch) and 4146 (unary minus operator applied to
unsigned type, result still unsigned).

Warning 4333 (right shift by too large amount, data loss) and 4345
(an object of POD type constructed with an initializer of the form ()
will be default-initialized) are no longer generated.

The same setting is applied and verified for GN build as well.

BUG=pdfium:29
Committed: https://pdfium.googlesource.com/pdfium/+/47ca692c8150cb39abef5737e866b91e6a105b80

[Wei Li, 2016-03-30 23:17:21]

Patchset #1 (id:1) has been deleted

[Wei Li, 2016-03-30 23:17:46]

weili@chromium.org changed reviewers:
+ tsepez@chromium.org

[Wei Li, 2016-03-30 23:17:47]

PTAL, thanks

[Tom Sepez, 2016-03-30 23:28:29]

https://codereview.chromium.org/1849443003/diff/20001/core/fpdfapi/fpdf_parse...
File core/fpdfapi/fpdf_parser/cpdf_data_avail.cpp (right):

https://codereview.chromium.org/1849443003/diff/20001/core/fpdfapi/fpdf_parse...
core/fpdfapi/fpdf_parser/cpdf_data_avail.cpp:719: if (offset > m_dwFileLen)
probably should check for < 0, as FX_FILESIZE is signed.

https://codereview.chromium.org/1849443003/diff/20001/core/fpdfapi/fpdf_parse...
core/fpdfapi/fpdf_parser/cpdf_data_avail.cpp:722: FX_SAFE_DWORD safeSize =
pdfium::base::checked_cast<uint32_t>(offset);
If this were a FX_SAFE_FILESIZE, we could avoid all the casts.

https://codereview.chromium.org/1849443003/diff/20001/core/fpdfapi/fpdf_parse...
File core/fpdfapi/fpdf_parser/cpdf_parser.cpp (right):

https://codereview.chromium.org/1849443003/diff/20001/core/fpdfapi/fpdf_parse...
core/fpdfapi/fpdf_parser/cpdf_parser.cpp:190: m_pSyntax->m_HeaderOffset + 9)
Maybe m_HeaderOffset should be a FX_FILESIZE, too.

https://codereview.chromium.org/1849443003/diff/20001/core/fxcrt/fx_basic_gcc...
File core/fxcrt/fx_basic_gcc_unittest.cpp (right):

https://codereview.chromium.org/1849443003/diff/20001/core/fxcrt/fx_basic_gcc...
core/fxcrt/fx_basic_gcc_unittest.cpp:20: EXPECT_EQ(-2147483647 - 1,
FXSYS_atoi("-2147483648"));
Not sure what's going on here.  Can you explain why we need to write it this
way?  Thanks.

[Wei Li, 2016-03-31 01:39:09]

https://codereview.chromium.org/1849443003/diff/20001/core/fpdfapi/fpdf_parse...
File core/fpdfapi/fpdf_parser/cpdf_data_avail.cpp (right):

https://codereview.chromium.org/1849443003/diff/20001/core/fpdfapi/fpdf_parse...
core/fpdfapi/fpdf_parser/cpdf_data_avail.cpp:719: if (offset > m_dwFileLen)
On 2016/03/30 23:28:28, Tom Sepez wrote:
> probably should check for < 0, as FX_FILESIZE is signed.

Done.

https://codereview.chromium.org/1849443003/diff/20001/core/fpdfapi/fpdf_parse...
core/fpdfapi/fpdf_parser/cpdf_data_avail.cpp:722: FX_SAFE_DWORD safeSize =
pdfium::base::checked_cast<uint32_t>(offset);
On 2016/03/30 23:28:28, Tom Sepez wrote:
> If this were a FX_SAFE_FILESIZE, we could avoid all the casts.

Good idea, done.

https://codereview.chromium.org/1849443003/diff/20001/core/fpdfapi/fpdf_parse...
File core/fpdfapi/fpdf_parser/cpdf_parser.cpp (right):

https://codereview.chromium.org/1849443003/diff/20001/core/fpdfapi/fpdf_parse...
core/fpdfapi/fpdf_parser/cpdf_parser.cpp:190: m_pSyntax->m_HeaderOffset + 9)
On 2016/03/30 23:28:28, Tom Sepez wrote:
> Maybe m_HeaderOffset should be a FX_FILESIZE, too.

Done.

https://codereview.chromium.org/1849443003/diff/20001/core/fxcrt/fx_basic_gcc...
File core/fxcrt/fx_basic_gcc_unittest.cpp (right):

https://codereview.chromium.org/1849443003/diff/20001/core/fxcrt/fx_basic_gcc...
core/fxcrt/fx_basic_gcc_unittest.cpp:20: EXPECT_EQ(-2147483647 - 1,
FXSYS_atoi("-2147483648"));
On 2016/03/30 23:28:29, Tom Sepez wrote:
> Not sure what's going on here.  Can you explain why we need to write it this
> way?  Thanks.

Since 2147483648 can not fit into int, it will be treated as an unsigned int.
Using minus before unsigned int raises the warning here. 

It is always a good idea to use INT_MIN whenever possible. But I think it is
better to see the test results visually here than using INT_MIN. WDYT?

[Tom Sepez, 2016-03-31 17:04:45]

lgtm

[Wei Li, 2016-03-31 22:08:08]

The CQ bit was checked by weili@chromium.org

[commit-bot: I haz the power, 2016-03-31 22:08:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1849443003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1849443003/40001

[commit-bot: I haz the power, 2016-03-31 22:08:29]

Description was changed from

==========
Re-enable all the windows warnings except 4267

The code is changed or had been changed to no longer generate these
warnings. It is safe to re-enabled these warnings.

In this code change, we fixed some code which generates warnings 4018
(signed/unsigned mismatch) and 4146 (unary minus operator applied to
unsigned type, result still unsigned).

Warning 4333 (right shift by too large amount, data loss) and 4345
(an object of POD type constructed with an initializer of the form ()
will be default-initialized) are no longer generated.

The same setting is applied and verified for GN build as well.

BUG=pdfium:29
==========

to

==========
Re-enable all the windows warnings except 4267

The code is changed or had been changed to no longer generate these
warnings. It is safe to re-enabled these warnings.

In this code change, we fixed some code which generates warnings 4018
(signed/unsigned mismatch) and 4146 (unary minus operator applied to
unsigned type, result still unsigned).

Warning 4333 (right shift by too large amount, data loss) and 4345
(an object of POD type constructed with an initializer of the form ()
will be default-initialized) are no longer generated.

The same setting is applied and verified for GN build as well.

BUG=pdfium:29

Committed:
https://pdfium.googlesource.com/pdfium/+/47ca692c8150cb39abef5737e866b91e6a10...
==========

[commit-bot: I haz the power, 2016-03-31 22:08:31]

Committed patchset #2 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/47ca692c8150cb39abef5737e866b91e6a10...

[Oliver Chang, 2016-04-04 23:25:52]

On 2016/03/31 22:08:31, commit-bot: I haz the power wrote:
> Committed patchset #2 (id:40001) as
>
https://pdfium.googlesource.com/pdfium/+/47ca692c8150cb39abef5737e866b91e6a10...

Looks like this is causing
https://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng...:

[9226/22192] CXX obj/third_party/pdfium/formfiller/cffl_iformfiller.obj
FAILED: ninja -t msvc -e environment.x86 -- E:\b\build\goma/gomacc.exe
"E:\b\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\VC\bin\amd64_x86/cl.exe"
/nologo /showIncludes /FC
@obj/third_party/pdfium/third_party/fx_libopenjpeg/dwt.obj.rsp /c
../../third_party/pdfium/third_party/libopenjpeg20/dwt.c
/Foobj/third_party/pdfium/third_party/fx_libopenjpeg/dwt.obj
/Fd"obj/third_party/pdfium/third_party/fx_libopenjpeg_c.pdb"
e:\b\build\slave\win_gn\build\src\third_party\pdfium\third_party\libopenjpeg20\dwt.c(296):
error C2220: warning treated as error - no 'object' file generated
e:\b\build\slave\win_gn\build\src\third_party\pdfium\third_party\libopenjpeg20\dwt.c(296):
warning C4018: '>=': signed/unsigned mismatch
e:\b\build\slave\win_gn\build\src\third_party\pdfium\third_party\libopenjpeg20\dwt.c(297):
warning C4018: '>=': signed/unsigned mismatch
e:\b\build\slave\win_gn\build\src\third_party\pdfium\third_party\libopenjpeg20\dwt.c(303):
warning C4018: '>=': signed/unsigned mismatch
e:\b\build\slave\win_gn\build\src\third_party\pdfium\third_party\libopenjpeg20\dwt.c(304):
warning C4018: '>=': signed/unsigned mismatch
e:\b\build\slave\win_gn\build\src\third_party\pdfium\third_party\libopenjpeg20\dwt.c(317):
warning C4018: '>=': signed/unsigned mismatch
e:\b\build\slave\win_gn\build\src\third_party\pdfium\third_party\libopenjpeg20\dwt.c(318):
warning C4018: '>=': signed/unsigned mismatch
e:\b\build\slave\win_gn\build\src\third_party\pdfium\third_party\libopenjpeg20\dwt.c(324):
warning C4018: '>=': signed/unsigned mismatch
e:\b\build\slave\win_gn\build\src\third_party\pdfium\third_party\libopenjpeg20\dwt.c(325):
warning C4018: '>=': signed/unsigned mismatch
e:\b\build\slave\win_gn\build\src\third_party\pdfium\third_party\libopenjpeg20\dwt.c(345):
warning C4018: '>=': signed/unsigned mismatch
e:\b\build\slave\win_gn\build\src\third_party\pdfium\third_party\libopenjpeg20\dwt.c(347):
warning C4018: '>=': signed/unsigned mismatch
e:\b\build\slave\win_gn\build\src\third_party\pdfium\third_party\libopenjpeg20\dwt.c(349):
warning C4018: '>=': signed/unsigned mismatch
e:\b\build\slave\win_gn\build\src\third_party\pdfium\third_party\libopenjpeg20\dwt.c(351):
warning C4018: '>=': signed/unsigned mismatch
e:\b\build\slave\win_gn\build\src\third_party\pdfium\third_party\libopenjpeg20\dwt.c(360):
warning C4018: '>=': signed/unsigned mismatch
e:\b\build\slave\win_gn\build\src\third_party\pdfium\third_party\libopenjpeg20\dwt.c(362):
warning C4018: '>=': signed/unsigned mismatch
e:\b\build\slave\win_gn\build\src\third_party\pdfium\third_party\libopenjpeg20\dwt.c(364):
warning C4018: '>=': signed/unsigned mismatch
e:\b\build\slave\win_gn\build\src\third_party\pdfium\third_party\libopenjpeg20\dwt.c(366):
warning C4018: '>=': signed/unsigned mismatch