Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Side by Side Diff: pdfium.gyp

Issue 1849443003: Re-enable all the windows warnings except 4267 (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Address comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « fpdfsdk/fpdfview.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 PDFium Authors. All rights reserved. 1 # Copyright 2015 PDFium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'variables': { 6 'variables': {
7 # TODO(thakis): Enable this, pdfium:29 7 # TODO(thakis): Enable this, pdfium:29
8 #'chromium_code': 1, 8 #'chromium_code': 1,
9 9
10 'variables': { 10 'variables': {
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 }], 86 }],
87 ], 87 ],
88 }], 88 }],
89 ['clang==1 and clang_use_pdfium_plugins==1', { 89 ['clang==1 and clang_use_pdfium_plugins==1', {
90 'cflags': [ 90 'cflags': [
91 '<@(clang_pdfium_plugins_flags)', 91 '<@(clang_pdfium_plugins_flags)',
92 ], 92 ],
93 }], 93 }],
94 ], 94 ],
95 'msvs_disabled_warnings': [ 95 'msvs_disabled_warnings': [
96 4018, 4146, 4333, 4345, 4267, 96 4267,
97 ], 97 ],
98 'variables': { 98 'variables': {
99 'clang_warning_flags': [ 99 'clang_warning_flags': [
100 # TODO(thestig): Fix all instances, remove this, pdfium:29 100 # TODO(thestig): Fix all instances, remove this, pdfium:29
101 '-Wno-sign-compare', 101 '-Wno-sign-compare',
102 ], 102 ],
103 # Make sure Chromium's build/common.gypi doesn't re-add the flag on linux. 103 # Make sure Chromium's build/common.gypi doesn't re-add the flag on linux.
104 'cflags_cc!': [ '-Wsign-compare' ], 104 'cflags_cc!': [ '-Wsign-compare' ],
105 }, 105 },
106 }, 106 },
(...skipping 931 matching lines...) Expand 10 before | Expand all | Expand 10 after
1038 'fpdfsdk/include/fpdfxfa/fpdfxfa_app.h', 1038 'fpdfsdk/include/fpdfxfa/fpdfxfa_app.h',
1039 'fpdfsdk/include/fpdfxfa/fpdfxfa_doc.h', 1039 'fpdfsdk/include/fpdfxfa/fpdfxfa_doc.h',
1040 'fpdfsdk/include/fpdfxfa/fpdfxfa_page.h', 1040 'fpdfsdk/include/fpdfxfa/fpdfxfa_page.h',
1041 'fpdfsdk/include/fpdfxfa/fpdfxfa_util.h', 1041 'fpdfsdk/include/fpdfxfa/fpdfxfa_util.h',
1042 ], 1042 ],
1043 }, 1043 },
1044 ] 1044 ]
1045 }], 1045 }],
1046 ] 1046 ]
1047 } 1047 }
OLDNEW
« no previous file with comments | « fpdfsdk/fpdfview.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698