Re-enable all the windows warnings except 4267

core/fxcrt/fx_basic_gcc_unittest.cpp

 // Copyright 2016 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/fxcrt/include/fx_system.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 TEST(fxcrt, FXSYS_atoi) {
   EXPECT_EQ(0, FXSYS_atoi(""));
   EXPECT_EQ(0, FXSYS_atoi("0"));
   EXPECT_EQ(-1, FXSYS_atoi("-1"));
   EXPECT_EQ(2345, FXSYS_atoi("2345"));
   EXPECT_EQ(-2147483647, FXSYS_atoi("-2147483647"));
   // Handle the sign.
   EXPECT_EQ(-2345, FXSYS_atoi("-2345"));
   EXPECT_EQ(2345, FXSYS_atoi("+2345"));
   // The max value.
   EXPECT_EQ(2147483647, FXSYS_atoi("2147483647"));
   // The min value.
-  EXPECT_EQ(-2147483648, FXSYS_atoi("-2147483648"));
+  EXPECT_EQ(-2147483647 - 1, FXSYS_atoi("-2147483648"));

[Tom Sepez, 2016/03/30 23:28:29]

Not sure what's going on here.  Can you explain why we need to write it this
way?  Thanks.

[Wei Li, 2016/03/31 01:39:09]

Since 2147483648 can not fit into int, it will be treated as an unsigned int.
Using minus before unsigned int raises the warning here. 

It is always a good idea to use INT_MIN whenever possible. But I think it is
better to see the test results visually here than using INT_MIN. WDYT?  

   // With invalid char.
   EXPECT_EQ(9, FXSYS_atoi("9x9"));
 
   // Out of range values.
   EXPECT_EQ(2147483647, FXSYS_atoi("2147483623423412348"));
   EXPECT_EQ(2147483647, FXSYS_atoi("2147483648"));
-  EXPECT_EQ(-2147483648, FXSYS_atoi("-2147483650"));
+  EXPECT_EQ(-2147483647 - 1, FXSYS_atoi("-2147483650"));
 }
 
 TEST(fxcrt, FXSYS_atoi64) {
   EXPECT_EQ(0, FXSYS_atoi64(""));
   EXPECT_EQ(0, FXSYS_atoi64("0"));
   EXPECT_EQ(-1, FXSYS_atoi64("-1"));
   EXPECT_EQ(2345, FXSYS_atoi64("2345"));
   EXPECT_EQ(-9223372036854775807LL, FXSYS_atoi64("-9223372036854775807"));
   // Handle the sign.
   EXPECT_EQ(-2345, FXSYS_atoi64("-2345"));
@@ skipping 13 matching lines @@
 
 TEST(fxcrt, FXSYS_wtoi) {
   EXPECT_EQ(0, FXSYS_wtoi(L""));
   EXPECT_EQ(0, FXSYS_wtoi(L"0"));
   EXPECT_EQ(-1, FXSYS_wtoi(L"-1"));
   EXPECT_EQ(2345, FXSYS_wtoi(L"2345"));
   EXPECT_EQ(-2147483647, FXSYS_wtoi(L"-2147483647"));
   // The max value.
   EXPECT_EQ(2147483647, FXSYS_wtoi(L"2147483647"));
   // The min value.
-  EXPECT_EQ(-2147483648, FXSYS_wtoi(L"-2147483648"));
+  EXPECT_EQ(-2147483647 - 1, FXSYS_wtoi(L"-2147483648"));
   EXPECT_EQ(9, FXSYS_wtoi64(L"9x9"));
 
   // Out of range values.
   EXPECT_EQ(2147483647, FXSYS_wtoi(L"2147483623423412348"));
   EXPECT_EQ(2147483647, FXSYS_wtoi(L"2147483648"));
-  EXPECT_EQ(-2147483648, FXSYS_wtoi(L"-2147483652"));
+  EXPECT_EQ(-2147483647 - 1, FXSYS_wtoi(L"-2147483652"));
 }
 
 TEST(fxcrt, FXSYS_wtoi64) {
   EXPECT_EQ(0, FXSYS_wtoi64(L""));
   EXPECT_EQ(0, FXSYS_wtoi64(L"0"));
   EXPECT_EQ(-1, FXSYS_wtoi64(L"-1"));
   EXPECT_EQ(2345, FXSYS_wtoi64(L"2345"));
   EXPECT_EQ(-9223372036854775807LL, FXSYS_wtoi64(L"-9223372036854775807"));
   // Handle the sign.
   EXPECT_EQ(-2345, FXSYS_wtoi64(L"-2345"));
@@ skipping 24 matching lines @@
   EXPECT_EQ(2345u, FXSYS_atoui("+2345"));
   // The max value.
   EXPECT_EQ(4294967295, FXSYS_atoui("4294967295"));
   EXPECT_EQ(9u, FXSYS_atoui("9x9"));
 
   // Out of range values.
   EXPECT_EQ(4294967295, FXSYS_atoui("2147483623423412348"));
   EXPECT_EQ(4294967295, FXSYS_atoui("4294967296"));
   EXPECT_EQ(4294967295, FXSYS_atoui("-4294967345"));
 }