Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Side by Side Diff: core/fpdfapi/fpdf_parser/cpdf_data_avail.cpp

Issue 1849443003: Re-enable all the windows warnings except 4267 (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Address comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « BUILD.gn ('k') | core/fpdfapi/fpdf_parser/cpdf_syntax_parser.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 PDFium Authors. All rights reserved. 1 // Copyright 2016 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "core/fpdfapi/fpdf_parser/include/ipdf_data_avail.h" 7 #include "core/fpdfapi/fpdf_parser/include/ipdf_data_avail.h"
8 8
9 #include "core/fpdfapi/fpdf_parser/cpdf_data_avail.h" 9 #include "core/fpdfapi/fpdf_parser/cpdf_data_avail.h"
10 #include "core/fpdfapi/fpdf_parser/fpdf_parser_utility.h" 10 #include "core/fpdfapi/fpdf_parser/fpdf_parser_utility.h"
(...skipping 698 matching lines...) Expand 10 before | Expand all | Expand 10 after
709 } 709 }
710 710
711 m_docStatus = 711 m_docStatus =
712 m_bSupportHintTable ? PDF_DATAAVAIL_HINTTABLE : PDF_DATAAVAIL_DONE; 712 m_bSupportHintTable ? PDF_DATAAVAIL_HINTTABLE : PDF_DATAAVAIL_DONE;
713 return TRUE; 713 return TRUE;
714 } 714 }
715 715
716 FX_BOOL CPDF_DataAvail::IsDataAvail(FX_FILESIZE offset, 716 FX_BOOL CPDF_DataAvail::IsDataAvail(FX_FILESIZE offset,
717 uint32_t size, 717 uint32_t size,
718 IPDF_DataAvail::DownloadHints* pHints) { 718 IPDF_DataAvail::DownloadHints* pHints) {
719 if (offset > m_dwFileLen) 719 if (offset < 0 || offset > m_dwFileLen)
720 return TRUE; 720 return TRUE;
721 721
722 FX_SAFE_DWORD safeSize = pdfium::base::checked_cast<uint32_t>(offset); 722 FX_SAFE_FILESIZE safeSize = offset;
723 safeSize += size; 723 safeSize += size;
724 safeSize += 512; 724 safeSize += 512;
725 if (!safeSize.IsValid() || safeSize.ValueOrDie() > m_dwFileLen) 725 if (!safeSize.IsValid() || safeSize.ValueOrDie() > m_dwFileLen)
726 size = m_dwFileLen - offset; 726 size = m_dwFileLen - offset;
727 else 727 else
728 size += 512; 728 size += 512;
729 729
730 if (!m_pFileAvail->IsDataAvail(offset, size)) { 730 if (!m_pFileAvail->IsDataAvail(offset, size)) {
731 pHints->AddSegment(offset, size); 731 pHints->AddSegment(offset, size);
732 return FALSE; 732 return FALSE;
(...skipping 1102 matching lines...) Expand 10 before | Expand all | Expand 10 after
1835 return FormAvailable; 1835 return FormAvailable;
1836 } 1836 }
1837 1837
1838 CPDF_DataAvail::PageNode::PageNode() : m_type(PDF_PAGENODE_UNKNOWN) {} 1838 CPDF_DataAvail::PageNode::PageNode() : m_type(PDF_PAGENODE_UNKNOWN) {}
1839 1839
1840 CPDF_DataAvail::PageNode::~PageNode() { 1840 CPDF_DataAvail::PageNode::~PageNode() {
1841 for (int32_t i = 0; i < m_childNode.GetSize(); ++i) 1841 for (int32_t i = 0; i < m_childNode.GetSize(); ++i)
1842 delete m_childNode[i]; 1842 delete m_childNode[i];
1843 m_childNode.RemoveAll(); 1843 m_childNode.RemoveAll();
1844 } 1844 }
OLDNEW
« no previous file with comments | « BUILD.gn ('k') | core/fpdfapi/fpdf_parser/cpdf_syntax_parser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698