Re-enable all the windows warnings except 4267

core/fpdfapi/fpdf_parser/cpdf_data_avail.cpp

 // Copyright 2016 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "core/fpdfapi/fpdf_parser/include/ipdf_data_avail.h"
 
 #include "core/fpdfapi/fpdf_parser/cpdf_data_avail.h"
 #include "core/fpdfapi/fpdf_parser/fpdf_parser_utility.h"
@@ skipping 698 matching lines @@
   }
 
   m_docStatus =
       m_bSupportHintTable ? PDF_DATAAVAIL_HINTTABLE : PDF_DATAAVAIL_DONE;
   return TRUE;
 }
 
 FX_BOOL CPDF_DataAvail::IsDataAvail(FX_FILESIZE offset,
                                     uint32_t size,
                                     IPDF_DataAvail::DownloadHints* pHints) {
   if (offset > m_dwFileLen)

[Tom Sepez, 2016/03/30 23:28:28]

probably should check for < 0, as FX_FILESIZE is signed.

[Wei Li, 2016/03/31 01:39:09]

Done.

     return TRUE;
 
   FX_SAFE_DWORD safeSize = pdfium::base::checked_cast<uint32_t>(offset);

[Tom Sepez, 2016/03/30 23:28:28]

If this were a FX_SAFE_FILESIZE, we could avoid all the casts.

[Wei Li, 2016/03/31 01:39:08]

Good idea, done.

   safeSize += size;
   safeSize += 512;
-  if (!safeSize.IsValid() || safeSize.ValueOrDie() > m_dwFileLen)
+  if (!safeSize.IsValid() ||
+      safeSize.ValueOrDie() > static_cast<uint32_t>(m_dwFileLen))
     size = m_dwFileLen - offset;
   else
     size += 512;
 
   if (!m_pFileAvail->IsDataAvail(offset, size)) {
     pHints->AddSegment(offset, size);
     return FALSE;
   }
   return TRUE;
 }
@@ skipping 1099 matching lines @@
   return FormAvailable;
 }
 
 CPDF_DataAvail::PageNode::PageNode() : m_type(PDF_PAGENODE_UNKNOWN) {}
 
 CPDF_DataAvail::PageNode::~PageNode() {
   for (int32_t i = 0; i < m_childNode.GetSize(); ++i)
     delete m_childNode[i];
   m_childNode.RemoveAll();
 }