BUILD.gn - Issue 1849443003: Re-enable all the windows warnings except 4267

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: BUILD.gn

Issue 1849443003: Re-enable all the windows warnings except 4267 (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Address comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: BUILD.gn

diff --git a/BUILD.gn b/BUILD.gn

index a21c0da26360cca57677ba258301126d77ae0eb4..d41937fa1c264cfe85da69f30ffb4b87c8b177da 100644

--- a/BUILD.gn

+++ b/BUILD.gn

@@ -43,24 +43,7 @@ config("pdfium_config") {

if (is_win) {

cflags += [

- "/wd4005",

- "/wd4018",

- "/wd4146",

- "/wd4333",

- "/wd4345",

"/wd4267",

- # TODO(ochang): Investigate if this can be fixed properly.

- "/wd4201",

- # TODO(thestig): Fix all instances, remove this, pdfium:29

- "/wd4245",

- "/wd4310",

- "/wd4389",

- "/wd4701",

- "/wd4702",

- "/wd4706",

- "/wd4800",

]

}

« no previous file with comments | « no previous file | core/fpdfapi/fpdf_parser/cpdf_data_avail.cpp » ('j') | no next file with comments »