Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1844843002: android: Remove in-process video path (Closed)

Created:
4 years, 8 months ago by boliu
Modified:
4 years, 8 months ago
Reviewers:
no sievers
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, avayvod+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, mlamouri+watch-media_chromium.org, Tobias Sargeant
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

android: Remove in-process video path CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel Committed: https://crrev.com/30f1b26acd2c15f4782c1c15dd2fa16173c5f5ef Cr-Commit-Position: refs/heads/master@{#388090}

Patch Set 1 #

Patch Set 2 : remove more #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : rebase r387995 #

Total comments: 2

Patch Set 6 : remove commented out code + rebase again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1505 lines) Patch
D content/browser/android/in_process/context_provider_in_process.h View 1 2 3 1 chunk +0 lines, -86 lines 0 comments Download
D content/browser/android/in_process/context_provider_in_process.cc View 1 2 3 1 chunk +0 lines, -186 lines 0 comments Download
M content/browser/android/in_process/synchronous_compositor_factory_impl.h View 1 2 2 chunks +0 lines, -52 lines 0 comments Download
M content/browser/android/in_process/synchronous_compositor_factory_impl.cc View 1 2 2 chunks +0 lines, -206 lines 0 comments Download
M content/browser/android/in_process/synchronous_compositor_impl.cc View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
M content/browser/android/synchronous_compositor_base.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/android/synchronous_compositor_base.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/android/synchronous_compositor_host.cc View 1 2 2 chunks +0 lines, -10 lines 0 comments Download
M content/browser/gpu/gpu_ipc_browsertests.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M content/content_browser.gypi View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M content/content_renderer.gypi View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/android/synchronous_compositor_factory.h View 1 2 1 chunk +0 lines, -9 lines 0 comments Download
M content/renderer/media/android/stream_texture_factory.h View 1 2 3 chunks +1 line, -9 lines 0 comments Download
M content/renderer/media/android/stream_texture_factory_impl.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/media/android/stream_texture_factory_impl.cc View 1 2 1 chunk +0 lines, -8 lines 0 comments Download
D content/renderer/media/android/stream_texture_factory_synchronous_impl.h View 1 chunk +0 lines, -81 lines 0 comments Download
D content/renderer/media/android/stream_texture_factory_synchronous_impl.cc View 1 2 1 chunk +0 lines, -210 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.h View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 1 2 3 chunks +0 lines, -18 lines 0 comments Download
M content/renderer/render_thread_impl.h View 1 2 3 4 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 3 4 2 chunks +4 lines, -18 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M gpu/blink/BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/blink/gpu_blink.gyp View 1 1 chunk +0 lines, -2 lines 0 comments Download
D gpu/blink/webgraphicscontext3d_in_process_command_buffer_impl.h View 1 2 1 chunk +0 lines, -91 lines 0 comments Download
D gpu/blink/webgraphicscontext3d_in_process_command_buffer_impl.cc View 1 2 1 chunk +0 lines, -130 lines 0 comments Download
M gpu/command_buffer/client/gl_in_process_context.h View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M gpu/command_buffer/client/gl_in_process_context.cc View 1 2 3 4 5 2 chunks +0 lines, -17 lines 0 comments Download
M gpu/command_buffer/service/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/in_process_command_buffer.h View 1 2 4 chunks +0 lines, -19 lines 0 comments Download
M gpu/command_buffer/service/in_process_command_buffer.cc View 1 2 5 chunks +0 lines, -42 lines 0 comments Download
D gpu/command_buffer/service/stream_texture_manager_in_process_android.h View 1 chunk +0 lines, -53 lines 0 comments Download
D gpu/command_buffer/service/stream_texture_manager_in_process_android.cc View 1 chunk +0 lines, -214 lines 0 comments Download
M gpu/command_buffer_service.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 26 (13 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844843002/1
4 years, 8 months ago (2016-03-30 03:20:00 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844843002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844843002/20001
4 years, 8 months ago (2016-03-30 04:15:55 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-30 05:41:21 UTC) #8
boliu
needed something to cheer me up, so sending this out Assuming nothing goes wrong with ...
4 years, 8 months ago (2016-04-13 23:52:42 UTC) #10
boliu
cc tobiasjs
4 years, 8 months ago (2016-04-14 02:04:04 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844843002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844843002/80001
4 years, 8 months ago (2016-04-18 20:26:12 UTC) #14
boliu
Calling it! Want to land this now. PTAL
4 years, 8 months ago (2016-04-18 20:26:23 UTC) #15
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_optional_gpu_tests_rel on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_tests_rel/builds/856)
4 years, 8 months ago (2016-04-18 20:29:55 UTC) #17
no sievers
LGTM! https://codereview.chromium.org/1844843002/diff/80001/gpu/command_buffer/client/gl_in_process_context.cc File gpu/command_buffer/client/gl_in_process_context.cc (right): https://codereview.chromium.org/1844843002/diff/80001/gpu/command_buffer/client/gl_in_process_context.cc#newcode205 gpu/command_buffer/client/gl_in_process_context.cc:205: #if defined(OS_ANDROID) you forgot to remove this block ...
4 years, 8 months ago (2016-04-18 23:00:50 UTC) #18
boliu
https://codereview.chromium.org/1844843002/diff/80001/gpu/command_buffer/client/gl_in_process_context.cc File gpu/command_buffer/client/gl_in_process_context.cc (right): https://codereview.chromium.org/1844843002/diff/80001/gpu/command_buffer/client/gl_in_process_context.cc#newcode205 gpu/command_buffer/client/gl_in_process_context.cc:205: #if defined(OS_ANDROID) On 2016/04/18 23:00:50, sievers wrote: > you ...
4 years, 8 months ago (2016-04-18 23:05:06 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844843002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844843002/100001
4 years, 8 months ago (2016-04-18 23:05:50 UTC) #22
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 8 months ago (2016-04-19 00:12:48 UTC) #24
commit-bot: I haz the power
4 years, 8 months ago (2016-04-19 00:13:51 UTC) #26
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/30f1b26acd2c15f4782c1c15dd2fa16173c5f5ef
Cr-Commit-Position: refs/heads/master@{#388090}

Powered by Google App Engine
This is Rietveld 408576698