Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 1838853005: android: Remove in-process sync compositor code path (Closed)

Created:
4 years, 8 months ago by boliu
Modified:
4 years, 8 months ago
Reviewers:
no sievers
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove_in_proc_video
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

android: Remove in-process sync compositor code path Remove the merge thread path. Also remove kIPCSyncCompositing and replace it with an android-only method on ContentClient. BUG=526842 Committed: https://crrev.com/66024c61d8dedbf67abe5ada9c521d0f6f909895 Cr-Commit-Position: refs/heads/master@{#388428}

Patch Set 1 #

Patch Set 2 : use ContentClient instead of switch #

Patch Set 3 : everything #

Patch Set 4 : use filter instead of ContentClient #

Patch Set 5 : ContentClient #

Patch Set 6 : rebase, RenderWidget use RenderThread #

Patch Set 7 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -1227 lines) Patch
M android_webview/common/aw_content_client.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M android_webview/common/aw_content_client.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java View 2 2 chunks +1 line, -4 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java View 1 2 2 chunks +1 line, -3 lines 0 comments Download
M android_webview/lib/main/aw_main_delegate.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
D content/browser/android/in_process/synchronous_compositor_factory_impl.h View 1 2 1 chunk +0 lines, -46 lines 0 comments Download
D content/browser/android/in_process/synchronous_compositor_factory_impl.cc View 1 2 1 chunk +0 lines, -74 lines 0 comments Download
D content/browser/android/in_process/synchronous_compositor_impl.h View 1 2 1 chunk +0 lines, -131 lines 0 comments Download
D content/browser/android/in_process/synchronous_compositor_impl.cc View 1 2 1 chunk +0 lines, -376 lines 0 comments Download
D content/browser/android/in_process/synchronous_compositor_registry_in_proc.h View 2 1 chunk +0 lines, -82 lines 0 comments Download
D content/browser/android/in_process/synchronous_compositor_registry_in_proc.cc View 2 1 chunk +0 lines, -173 lines 0 comments Download
D content/browser/android/in_process/synchronous_input_event_filter.h View 2 1 chunk +0 lines, -64 lines 0 comments Download
D content/browser/android/in_process/synchronous_input_event_filter.cc View 2 3 4 5 6 1 chunk +0 lines, -91 lines 0 comments Download
M content/browser/android/synchronous_compositor_base.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/android/synchronous_compositor_base.cc View 1 2 2 chunks +7 lines, -12 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 4 5 6 3 chunks +2 lines, -5 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 4 5 6 1 chunk +0 lines, -8 lines 0 comments Download
M content/content_renderer.gypi View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/common/ContentSwitches.java View 2 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/common/content_client.h View 1 1 chunk +7 lines, -0 lines 0 comments Download
M content/public/common/content_client.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 2 3 4 5 1 chunk +0 lines, -3 lines 0 comments Download
D content/renderer/android/synchronous_compositor_factory.h View 1 2 1 chunk +0 lines, -65 lines 0 comments Download
D content/renderer/android/synchronous_compositor_factory.cc View 2 1 chunk +0 lines, -27 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 2 3 4 5 6 3 chunks +2 lines, -5 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 3 4 5 3 chunks +13 lines, -40 lines 0 comments Download
M content/renderer/render_widget.cc View 1 2 3 4 5 6 2 chunks +4 lines, -10 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
boliu
Part 2 \o/
4 years, 8 months ago (2016-04-19 17:37:42 UTC) #3
no sievers
lgtm
4 years, 8 months ago (2016-04-19 23:04:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1838853005/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1838853005/120001
4 years, 8 months ago (2016-04-20 01:48:24 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/214089)
4 years, 8 months ago (2016-04-20 03:22:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1838853005/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1838853005/120001
4 years, 8 months ago (2016-04-20 03:27:34 UTC) #11
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 8 months ago (2016-04-20 04:00:50 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:20:57 UTC) #15
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/66024c61d8dedbf67abe5ada9c521d0f6f909895
Cr-Commit-Position: refs/heads/master@{#388428}

Powered by Google App Engine
This is Rietveld 408576698