Code change to avoid signed/unsigned mismatch warnings

Code change to avoid signed/unsigned mismatch warnings.

This makes pdfium code on Linux and Mac sign-compare warning free.
The warning flag will be re-enabled after checking on windows clang build.

BUG=pdfium:29
R=tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/05d53f0355e9889c43bfa436e985d5643f249d99

[Wei Li, 2016-03-29 19:33:18]

Patchset #1 (id:1) has been deleted

[Wei Li, 2016-03-29 19:43:25]

Patchset #1 (id:20001) has been deleted

[Wei Li, 2016-03-29 19:46:19]

Description was changed from

==========
Reduce signed/unsigned mismatch warnings

BUG=pdfium:29
==========

to

==========
Code change to avoid signed/unsigned mismatch warnings.

This makes pdfium code on Linux and Mac sign-compare warning free. The warning
flag will be reenabled after checking on windows clang build.

BUG=pdfium:29
==========

[Wei Li, 2016-03-29 19:46:19]

weili@chromium.org changed reviewers:
+ tsepez@chromium.org

[Wei Li, 2016-03-29 19:46:33]

PTAL, thanks

[Tom Sepez, 2016-03-29 20:29:01]

lgtm

https://codereview.chromium.org/1841643002/diff/60001/fpdfsdk/fpdfview.cpp
File fpdfsdk/fpdfview.cpp (right):

https://codereview.chromium.org/1841643002/diff/60001/fpdfsdk/fpdfview.cpp#ne...
fpdfsdk/fpdfview.cpp:198: newPos.ValueOrDie() >
static_cast<FX_FILESIZE>(m_FileAccess.m_FileLen)) {
m_FileLen probably should remaing a FX_FILESIZE until we tackle that issue.

[Wei Li, 2016-03-29 22:21:00]

thanks

https://codereview.chromium.org/1841643002/diff/60001/fpdfsdk/fpdfview.cpp
File fpdfsdk/fpdfview.cpp (right):

https://codereview.chromium.org/1841643002/diff/60001/fpdfsdk/fpdfview.cpp#ne...
fpdfsdk/fpdfview.cpp:198: newPos.ValueOrDie() >
static_cast<FX_FILESIZE>(m_FileAccess.m_FileLen)) {
On 2016/03/29 20:29:01, Tom Sepez wrote:
> m_FileLen probably should remaing a FX_FILESIZE until we tackle that issue.

You meant changing m_FileLen's type to FX_FILESIZE? That was my earlier attempt
too. Unfortunately, FPDF_FILEACCESS is defined in /public, and is already used
outside of pdfium.

[Wei Li, 2016-03-29 22:29:20]

Description was changed from

==========
Code change to avoid signed/unsigned mismatch warnings.

This makes pdfium code on Linux and Mac sign-compare warning free. The warning
flag will be reenabled after checking on windows clang build.

BUG=pdfium:29
==========

to

==========
Code change to avoid signed/unsigned mismatch warnings.

This makes pdfium code on Linux and Mac sign-compare warning free.
The warning flag will be re-enabled after checking on windows clang build.

BUG=pdfium:29
==========

[Tom Sepez, 2016-03-29 23:20:19]

On 2016/03/29 22:21:00, Wei Li wrote:
> thanks
> 
> https://codereview.chromium.org/1841643002/diff/60001/fpdfsdk/fpdfview.cpp
> File fpdfsdk/fpdfview.cpp (right):
> 
>
https://codereview.chromium.org/1841643002/diff/60001/fpdfsdk/fpdfview.cpp#ne...
> fpdfsdk/fpdfview.cpp:198: newPos.ValueOrDie() >
> static_cast<FX_FILESIZE>(m_FileAccess.m_FileLen)) {
> On 2016/03/29 20:29:01, Tom Sepez wrote:
> > m_FileLen probably should remaing a FX_FILESIZE until we tackle that issue.
> 
> You meant changing m_FileLen's type to FX_FILESIZE? That was my earlier
attempt
> too. Unfortunately, FPDF_FILEACCESS is defined in /public, and is already used
> outside of pdfium.

Ok, that's fine as is.  Thanks.

[Wei Li, 2016-03-29 23:42:58]

Description was changed from

==========
Code change to avoid signed/unsigned mismatch warnings.

This makes pdfium code on Linux and Mac sign-compare warning free.
The warning flag will be re-enabled after checking on windows clang build.

BUG=pdfium:29
==========

to

==========
Code change to avoid signed/unsigned mismatch warnings.

This makes pdfium code on Linux and Mac sign-compare warning free.
The warning flag will be re-enabled after checking on windows clang build.

BUG=pdfium:29
R=tsepez@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/05d53f0355e9889c43bfa436e985d5643f24...
==========

[Wei Li, 2016-03-29 23:42:59]

Committed patchset #3 (id:80001) manually as
05d53f0355e9889c43bfa436e985d5643f249d99 (presubmit successful).