fpdfsdk/fpdfsave_embeddertest.cpp - Issue 1841643002: Code change to avoid signed/unsigned mismatch warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/fpdfsave_embeddertest.cpp

Issue 1841643002: Code change to avoid signed/unsigned mismatch warnings (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: rebase Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/fpdfsave_embeddertest.cpp

diff --git a/fpdfsdk/fpdfsave_embeddertest.cpp b/fpdfsdk/fpdfsave_embeddertest.cpp

index 2b138a61e4bf1a9cb57ec380d7fe9cbaf482d731..5dbff36327c8563dd6dc96cc665bf545d73256af 100644

--- a/fpdfsdk/fpdfsave_embeddertest.cpp

+++ b/fpdfsdk/fpdfsave_embeddertest.cpp

@@ -19,14 +19,14 @@ TEST_F(FPDFSaveEmbedderTest, SaveSimpleDoc) {

EXPECT_TRUE(OpenDocument("hello_world.pdf"));

EXPECT_TRUE(FPDF_SaveAsCopy(document(), this, 0));

EXPECT_THAT(GetString(), testing::StartsWith("%PDF-1.7\r\n"));

- EXPECT_EQ(843, GetString().length());

+ EXPECT_EQ(843u, GetString().length());

}

TEST_F(FPDFSaveEmbedderTest, SaveSimpleDocWithVersion) {

EXPECT_TRUE(OpenDocument("hello_world.pdf"));

EXPECT_TRUE(FPDF_SaveWithVersion(document(), this, 0, 14));

EXPECT_THAT(GetString(), testing::StartsWith("%PDF-1.4\r\n"));

- EXPECT_EQ(843, GetString().length());

+ EXPECT_EQ(843u, GetString().length());

}

TEST_F(FPDFSaveEmbedderTest, SaveSimpleDocWithBadVersion) {

« no previous file with comments | « fpdfsdk/fpdfdoc_embeddertest.cpp ('k') | fpdfsdk/fpdftext_embeddertest.cpp » ('j') | no next file with comments »