Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Unified Diff: core/fpdfapi/fpdf_page/fpdf_page_parser_old_unittest.cpp

Issue 1841643002: Code change to avoid signed/unsigned mismatch warnings (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « core/fpdfapi/fpdf_page/fpdf_page_parser.cpp ('k') | core/fpdfapi/fpdf_page/pageint.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/fpdfapi/fpdf_page/fpdf_page_parser_old_unittest.cpp
diff --git a/core/fpdfapi/fpdf_page/fpdf_page_parser_old_unittest.cpp b/core/fpdfapi/fpdf_page/fpdf_page_parser_old_unittest.cpp
index f4c33d2811e4698dffb58ce6cb06e50991e7f32b..ff15b21d739cab25b4dee3dccca8ff845a80f357 100644
--- a/core/fpdfapi/fpdf_page/fpdf_page_parser_old_unittest.cpp
+++ b/core/fpdfapi/fpdf_page/fpdf_page_parser_old_unittest.cpp
@@ -19,7 +19,7 @@ TEST(fpdf_page_parser_old, ReadHexString) {
uint8_t data[] = "1A2b>abcd";
CPDF_StreamParser parser(data, 5);
EXPECT_EQ("\x1a\x2b", parser.ReadHexString());
- EXPECT_EQ(5, parser.GetPos());
+ EXPECT_EQ(5u, parser.GetPos());
}
{
@@ -27,7 +27,7 @@ TEST(fpdf_page_parser_old, ReadHexString) {
uint8_t data[] = "1A2b";
CPDF_StreamParser parser(data, 5);
EXPECT_EQ("\x1a\x2b", parser.ReadHexString());
- EXPECT_EQ(5, parser.GetPos());
+ EXPECT_EQ(5u, parser.GetPos());
}
{
@@ -35,13 +35,13 @@ TEST(fpdf_page_parser_old, ReadHexString) {
uint8_t data[] = "1A2>asdf";
CPDF_StreamParser parser(data, 5);
EXPECT_EQ("\x1a\x20", parser.ReadHexString());
- EXPECT_EQ(4, parser.GetPos());
+ EXPECT_EQ(4u, parser.GetPos());
}
{
uint8_t data[] = ">";
CPDF_StreamParser parser(data, 5);
EXPECT_EQ("", parser.ReadHexString());
- EXPECT_EQ(1, parser.GetPos());
+ EXPECT_EQ(1u, parser.GetPos());
}
}
« no previous file with comments | « core/fpdfapi/fpdf_page/fpdf_page_parser.cpp ('k') | core/fpdfapi/fpdf_page/pageint.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698