core/fpdfapi/fpdf_parser/include/cpdf_array.h - Issue 1841643002: Code change to avoid signed/unsigned mismatch warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_parser/include/cpdf_array.h

Issue 1841643002: Code change to avoid signed/unsigned mismatch warnings (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: rebase Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_parser/include/cpdf_array.h

diff --git a/core/fpdfapi/fpdf_parser/include/cpdf_array.h b/core/fpdfapi/fpdf_parser/include/cpdf_array.h

index ea367785ed347022921c5f915c71059d1c3ba717..b964f4955b6e81849b997e35384fd70a8a6a4aa3 100644

--- a/core/fpdfapi/fpdf_parser/include/cpdf_array.h

+++ b/core/fpdfapi/fpdf_parser/include/cpdf_array.h

@@ -44,7 +44,7 @@ class CPDF_Array : public CPDF_Object {

void InsertAt(uint32_t index,

CPDF_Object* pObj,

CPDF_IndirectObjectHolder* pObjs = nullptr);

- void RemoveAt(uint32_t index, int nCount = 1);

+ void RemoveAt(uint32_t index, uint32_t nCount = 1);

void Add(CPDF_Object* pObj, CPDF_IndirectObjectHolder* pObjs = nullptr);

void AddNumber(FX_FLOAT f);