fpdfsdk/fpdfview.cpp - Issue 1841643002: Code change to avoid signed/unsigned mismatch warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/fpdfview.cpp

Issue 1841643002: Code change to avoid signed/unsigned mismatch warnings (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: rebase Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/fpdfview.cpp

diff --git a/fpdfsdk/fpdfview.cpp b/fpdfsdk/fpdfview.cpp

index 9995fc042695c5a0eafad9b60061678edaece701..9183b4073b43f7d0ce2ea40ffa1e1909f2eab3c4 100644

--- a/fpdfsdk/fpdfview.cpp

+++ b/fpdfsdk/fpdfview.cpp

@@ -194,7 +194,8 @@ FX_BOOL CPDF_CustomAccess::ReadBlock(void* buffer,

FX_SAFE_FILESIZE newPos =

pdfium::base::checked_cast<FX_FILESIZE, size_t>(size);

newPos += offset;

- if (!newPos.IsValid() || newPos.ValueOrDie() > m_FileAccess.m_FileLen) {

+ if (!newPos.IsValid() ||

+ newPos.ValueOrDie() > static_cast<FX_FILESIZE>(m_FileAccess.m_FileLen)) {

return FALSE;

}

return m_FileAccess.m_GetBlock(m_FileAccess.m_Param, offset, (uint8_t*)buffer,

« no previous file with comments | « fpdfsdk/fpdftext_embeddertest.cpp ('k') | fpdfsdk/fpdfview_embeddertest.cpp » ('j') | no next file with comments »