Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Side by Side Diff: core/fpdfapi/fpdf_font/fpdf_font_cid_unittest.cpp

Issue 1841643002: Code change to avoid signed/unsigned mismatch warnings (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « core/fpdfapi/fpdf_font/fpdf_font.cpp ('k') | core/fpdfapi/fpdf_font/fpdf_font_unittest.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 PDFium Authors. All rights reserved. 1 // Copyright 2015 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/fpdfapi/fpdf_font/font_int.h" 5 #include "core/fpdfapi/fpdf_font/font_int.h"
6 #include "testing/gtest/include/gtest/gtest.h" 6 #include "testing/gtest/include/gtest/gtest.h"
7 7
8 namespace { 8 namespace {
9 9
10 bool uint_ranges_equal(uint8_t* a, uint8_t* b, size_t count) { 10 bool uint_ranges_equal(uint8_t* a, uint8_t* b, size_t count) {
11 for (size_t i = 0; i < count; ++i) { 11 for (size_t i = 0; i < count; ++i) {
12 if (a[i] != b[i]) 12 if (a[i] != b[i])
13 return false; 13 return false;
14 } 14 }
15 return true; 15 return true;
16 } 16 }
17 17
18 } // namespace 18 } // namespace
19 19
20 TEST(fpdf_font_cid, CMap_GetCode) { 20 TEST(fpdf_font_cid, CMap_GetCode) {
21 EXPECT_EQ(0, CPDF_CMapParser::CMap_GetCode("")); 21 EXPECT_EQ(0u, CPDF_CMapParser::CMap_GetCode(""));
22 EXPECT_EQ(0, CPDF_CMapParser::CMap_GetCode("<")); 22 EXPECT_EQ(0u, CPDF_CMapParser::CMap_GetCode("<"));
23 EXPECT_EQ(194, CPDF_CMapParser::CMap_GetCode("<c2")); 23 EXPECT_EQ(194u, CPDF_CMapParser::CMap_GetCode("<c2"));
24 EXPECT_EQ(162, CPDF_CMapParser::CMap_GetCode("<A2")); 24 EXPECT_EQ(162u, CPDF_CMapParser::CMap_GetCode("<A2"));
25 EXPECT_EQ(2802, CPDF_CMapParser::CMap_GetCode("<Af2")); 25 EXPECT_EQ(2802u, CPDF_CMapParser::CMap_GetCode("<Af2"));
26 EXPECT_EQ(162, CPDF_CMapParser::CMap_GetCode("<A2z")); 26 EXPECT_EQ(162u, CPDF_CMapParser::CMap_GetCode("<A2z"));
27 27
28 EXPECT_EQ(12, CPDF_CMapParser::CMap_GetCode("12")); 28 EXPECT_EQ(12u, CPDF_CMapParser::CMap_GetCode("12"));
29 EXPECT_EQ(12, CPDF_CMapParser::CMap_GetCode("12d")); 29 EXPECT_EQ(12u, CPDF_CMapParser::CMap_GetCode("12d"));
30 EXPECT_EQ(128, CPDF_CMapParser::CMap_GetCode("128")); 30 EXPECT_EQ(128u, CPDF_CMapParser::CMap_GetCode("128"));
31 } 31 }
32 32
33 TEST(fpdf_font_cid, CMap_GetCodeRange) { 33 TEST(fpdf_font_cid, CMap_GetCodeRange) {
34 CMap_CodeRange range; 34 CMap_CodeRange range;
35 35
36 // Must start with a < 36 // Must start with a <
37 EXPECT_FALSE(CPDF_CMapParser::CMap_GetCodeRange(range, "", "")); 37 EXPECT_FALSE(CPDF_CMapParser::CMap_GetCodeRange(range, "", ""));
38 EXPECT_FALSE(CPDF_CMapParser::CMap_GetCodeRange(range, "A", "")); 38 EXPECT_FALSE(CPDF_CMapParser::CMap_GetCodeRange(range, "A", ""));
39 39
40 // m_CharSize must be <= 4 40 // m_CharSize must be <= 4
(...skipping 15 matching lines...) Expand all
56 EXPECT_EQ(1, range.m_CharSize); 56 EXPECT_EQ(1, range.m_CharSize);
57 EXPECT_EQ(161, range.m_Lower[0]); 57 EXPECT_EQ(161, range.m_Lower[0]);
58 EXPECT_EQ(243, range.m_Upper[0]); 58 EXPECT_EQ(243, range.m_Upper[0]);
59 59
60 // The second string should return 0's if it is shorter 60 // The second string should return 0's if it is shorter
61 EXPECT_TRUE(CPDF_CMapParser::CMap_GetCodeRange(range, "<a1>", "")); 61 EXPECT_TRUE(CPDF_CMapParser::CMap_GetCodeRange(range, "<a1>", ""));
62 EXPECT_EQ(1, range.m_CharSize); 62 EXPECT_EQ(1, range.m_CharSize);
63 EXPECT_EQ(161, range.m_Lower[0]); 63 EXPECT_EQ(161, range.m_Lower[0]);
64 EXPECT_EQ(0, range.m_Upper[0]); 64 EXPECT_EQ(0, range.m_Upper[0]);
65 } 65 }
OLDNEW
« no previous file with comments | « core/fpdfapi/fpdf_font/fpdf_font.cpp ('k') | core/fpdfapi/fpdf_font/fpdf_font_unittest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698