cc: Remove BeginFrameSource::Create methods

cc: Remove BeginFrameSource::Create methods

These don't do anything but force the object to be created in the heap
and then wrap them in a scoped_ptr.  Callers can do that themselves without
needing a second, static copy of every constructor.

R=danakj@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/58765cfdaa92549be372ac2965cbcc4cef30f7ff
Cr-Commit-Position: refs/heads/master@{#383863}

[enne (OOO), 2016-03-29 21:03:44]

Description was changed from

==========
cc: Remove BeginFrameSource::Create methods

These don't do anything but force the object to be created in the heap
and then wrap them in a scoped_ptr.  Callers can do that themselves without
needing a second, static copy of every constructor.

R=danakj@chromium.org
==========

to

==========
cc: Remove BeginFrameSource::Create methods

These don't do anything but force the object to be created in the heap
and then wrap them in a scoped_ptr.  Callers can do that themselves without
needing a second, static copy of every constructor.

R=danakj@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[danakj, 2016-03-29 21:32:32]

LGTM

https://codereview.chromium.org/1840223002/diff/1/cc/scheduler/begin_frame_so...
File cc/scheduler/begin_frame_source.h (right):

https://codereview.chromium.org/1840223002/diff/1/cc/scheduler/begin_frame_so...
cc/scheduler/begin_frame_source.h:218: scoped_ptr<DelayBasedTimeSource>
time_source);
This one is only meant for subclasses?

[enne (OOO), 2016-03-29 21:35:14]

https://codereview.chromium.org/1840223002/diff/1/cc/scheduler/begin_frame_so...
File cc/scheduler/begin_frame_source.h (right):

https://codereview.chromium.org/1840223002/diff/1/cc/scheduler/begin_frame_so...
cc/scheduler/begin_frame_source.h:218: scoped_ptr<DelayBasedTimeSource>
time_source);
On 2016/03/29 at 21:32:32, danakj wrote:
> This one is only meant for subclasses?

That is how it is currently used, yes.  But, I don't see any reason why it needs
to be protected.  It's just as legit.

[enne (OOO), 2016-03-29 21:38:45]

enne@chromium.org changed reviewers:
+ fsamuel@chromium.org

[enne (OOO), 2016-03-29 21:38:59]

+fsamuel for components/mus/

[Fady Samuel, 2016-03-29 21:40:32]

mus lgtm

[enne (OOO), 2016-03-29 21:58:44]

The CQ bit was checked by enne@chromium.org

[enne (OOO), 2016-03-29 21:58:44]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/1840223002/#ps20001
(title: "Fix test BFS and mus too")

[commit-bot: I haz the power, 2016-03-29 21:59:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1840223002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1840223002/20001

[commit-bot: I haz the power, 2016-03-29 23:35:42]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-29 23:36:57]

Description was changed from

==========
cc: Remove BeginFrameSource::Create methods

These don't do anything but force the object to be created in the heap
and then wrap them in a scoped_ptr.  Callers can do that themselves without
needing a second, static copy of every constructor.

R=danakj@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Remove BeginFrameSource::Create methods

These don't do anything but force the object to be created in the heap
and then wrap them in a scoped_ptr.  Callers can do that themselves without
needing a second, static copy of every constructor.

R=danakj@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/58765cfdaa92549be372ac2965cbcc4cef30f7ff
Cr-Commit-Position: refs/heads/master@{#383863}
==========

[commit-bot: I haz the power, 2016-03-29 23:36:58]

Patchset 2 (id:??) landed as
https://crrev.com/58765cfdaa92549be372ac2965cbcc4cef30f7ff
Cr-Commit-Position: refs/heads/master@{#383863}