Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3583)

Unified Diff: cc/scheduler/begin_frame_source_unittest.cc

Issue 1840223002: cc: Remove BeginFrameSource::Create methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test BFS and mus too Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/scheduler/begin_frame_source.cc ('k') | cc/scheduler/scheduler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/scheduler/begin_frame_source_unittest.cc
diff --git a/cc/scheduler/begin_frame_source_unittest.cc b/cc/scheduler/begin_frame_source_unittest.cc
index 418fd32374a94f50bf5153429170a326aaf6b88e..37b0a639b157670ebe4c6ec9bc1b3538151d52c0 100644
--- a/cc/scheduler/begin_frame_source_unittest.cc
+++ b/cc/scheduler/begin_frame_source_unittest.cc
@@ -207,18 +207,11 @@ TEST(BeginFrameSourceBaseTest, DetectAsValueIntoLoop) {
// BackToBackBeginFrameSource testing -----------------------------------------
class TestBackToBackBeginFrameSource : public BackToBackBeginFrameSource {
public:
- static scoped_ptr<TestBackToBackBeginFrameSource> Create(
- base::SimpleTestTickClock* now_src,
- base::SingleThreadTaskRunner* task_runner) {
- return make_scoped_ptr(
- new TestBackToBackBeginFrameSource(now_src, task_runner));
- }
-
- protected:
TestBackToBackBeginFrameSource(base::SimpleTestTickClock* now_src,
base::SingleThreadTaskRunner* task_runner)
: BackToBackBeginFrameSource(task_runner), now_src_(now_src) {}
+ protected:
base::TimeTicks Now() override { return now_src_->NowTicks(); }
// Not owned.
@@ -240,8 +233,8 @@ class BackToBackBeginFrameSourceTest : public ::testing::Test {
now_src_->Advance(base::TimeDelta::FromMicroseconds(1000));
task_runner_ =
make_scoped_refptr(new OrderedSimpleTaskRunner(now_src_.get(), false));
- source_ = TestBackToBackBeginFrameSource::Create(now_src_.get(),
- task_runner_.get());
+ source_.reset(
+ new TestBackToBackBeginFrameSource(now_src_.get(), task_runner_.get()));
obs_ = make_scoped_ptr(new ::testing::StrictMock<MockBeginFrameObserver>());
}
@@ -419,9 +412,9 @@ class SyntheticBeginFrameSourceTest : public ::testing::Test {
now_src_->Advance(base::TimeDelta::FromMicroseconds(1000));
task_runner_ =
make_scoped_refptr(new OrderedSimpleTaskRunner(now_src_.get(), false));
- source_ = TestSyntheticBeginFrameSource::Create(
+ source_.reset(new TestSyntheticBeginFrameSource(
now_src_.get(), task_runner_.get(),
- base::TimeDelta::FromMicroseconds(10000));
+ base::TimeDelta::FromMicroseconds(10000)));
obs_ = make_scoped_ptr(new MockBeginFrameObserver());
}
« no previous file with comments | « cc/scheduler/begin_frame_source.cc ('k') | cc/scheduler/scheduler_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698