cc: Remove BeginFrameSource::Create methods

cc/scheduler/begin_frame_source.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_SCHEDULER_BEGIN_FRAME_SOURCE_H_
 #define CC_SCHEDULER_BEGIN_FRAME_SOURCE_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 160 matching lines @@
  private:
   bool inside_as_value_into_;
 
   DISALLOW_COPY_AND_ASSIGN(BeginFrameSourceBase);
 };
 
 // A frame source which calls BeginFrame (at the next possible time) as soon as
 // remaining frames reaches zero.
 class CC_EXPORT BackToBackBeginFrameSource : public BeginFrameSourceBase {
  public:
-  static scoped_ptr<BackToBackBeginFrameSource> Create(
+  explicit BackToBackBeginFrameSource(
       base::SingleThreadTaskRunner* task_runner);
   ~BackToBackBeginFrameSource() override;
 
   // BeginFrameSource
   void DidFinishFrame(size_t remaining_frames) override;
 
   // BeginFrameSourceBase
   void AddObserver(BeginFrameObserver* obs) override;
   void OnNeedsBeginFramesChanged(bool needs_begin_frames) override;
 
   // Tracing
   void AsValueInto(base::trace_event::TracedValue* dict) const override;
 
  protected:
-  explicit BackToBackBeginFrameSource(
-      base::SingleThreadTaskRunner* task_runner);
   virtual base::TimeTicks Now();  // Now overridable for testing
 
   base::SingleThreadTaskRunner* task_runner_;
   base::CancelableClosure begin_frame_task_;
 
   void PostBeginFrame();
   void BeginFrame();
 
  private:
   base::WeakPtrFactory<BackToBackBeginFrameSource> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(BackToBackBeginFrameSource);
 };
 
 // A frame source which is locked to an external parameters provides from a
 // vsync source and generates BeginFrameArgs for it.
 class CC_EXPORT SyntheticBeginFrameSource : public BeginFrameSourceBase,
                                             public DelayBasedTimeSourceClient {
  public:
-  static scoped_ptr<SyntheticBeginFrameSource> Create(
-      base::SingleThreadTaskRunner* task_runner,
-      base::TimeDelta initial_vsync_interval);
+  explicit SyntheticBeginFrameSource(base::SingleThreadTaskRunner* task_runner,
+                                     base::TimeDelta initial_vsync_interval);
+  explicit SyntheticBeginFrameSource(
+      scoped_ptr<DelayBasedTimeSource> time_source);

[danakj, 2016/03/29 21:32:32]

This one is only meant for subclasses?

[enne (OOO), 2016/03/29 21:35:14]

That is how it is currently used, yes.  But, I don't see any reason why it needs
to be protected.  It's just as legit.

   ~SyntheticBeginFrameSource() override;
 
   void OnUpdateVSyncParameters(base::TimeTicks new_vsync_timebase,
                                base::TimeDelta new_vsync_interval);
 
   // BeginFrameSourceBase
   void AddObserver(BeginFrameObserver* obs) override;
   void OnNeedsBeginFramesChanged(bool needs_begin_frames) override;
 
   // Tracing
   void AsValueInto(base::trace_event::TracedValue* dict) const override;
 
   // DelayBasedTimeSourceClient
   void OnTimerTick() override;
 
  protected:
-  explicit SyntheticBeginFrameSource(
-      scoped_ptr<DelayBasedTimeSource> time_source);
-
   BeginFrameArgs CreateBeginFrameArgs(base::TimeTicks frame_time,
                                       BeginFrameArgs::BeginFrameArgsType type);
 
   scoped_ptr<DelayBasedTimeSource> time_source_;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(SyntheticBeginFrameSource);
 };
 
 }  // namespace cc
 
 #endif  // CC_SCHEDULER_BEGIN_FRAME_SOURCE_H_