Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Side by Side Diff: cc/scheduler/begin_frame_source_unittest.cc

Issue 1840223002: cc: Remove BeginFrameSource::Create methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test BFS and mus too Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/scheduler/begin_frame_source.cc ('k') | cc/scheduler/scheduler_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 The Chromium Authors. All rights reserved. 1 // Copyright 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/scheduler/begin_frame_source.h" 5 #include "cc/scheduler/begin_frame_source.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include "base/test/test_simple_task_runner.h" 9 #include "base/test/test_simple_task_runner.h"
10 #include "cc/test/begin_frame_args_test.h" 10 #include "cc/test/begin_frame_args_test.h"
(...skipping 189 matching lines...) Expand 10 before | Expand all | Expand 10 after
200 source.AddObserver(&obs); 200 source.AddObserver(&obs);
201 201
202 scoped_ptr<base::trace_event::TracedValue> state( 202 scoped_ptr<base::trace_event::TracedValue> state(
203 new base::trace_event::TracedValue()); 203 new base::trace_event::TracedValue());
204 source.AsValueInto(state.get()); 204 source.AsValueInto(state.get());
205 } 205 }
206 206
207 // BackToBackBeginFrameSource testing ----------------------------------------- 207 // BackToBackBeginFrameSource testing -----------------------------------------
208 class TestBackToBackBeginFrameSource : public BackToBackBeginFrameSource { 208 class TestBackToBackBeginFrameSource : public BackToBackBeginFrameSource {
209 public: 209 public:
210 static scoped_ptr<TestBackToBackBeginFrameSource> Create(
211 base::SimpleTestTickClock* now_src,
212 base::SingleThreadTaskRunner* task_runner) {
213 return make_scoped_ptr(
214 new TestBackToBackBeginFrameSource(now_src, task_runner));
215 }
216
217 protected:
218 TestBackToBackBeginFrameSource(base::SimpleTestTickClock* now_src, 210 TestBackToBackBeginFrameSource(base::SimpleTestTickClock* now_src,
219 base::SingleThreadTaskRunner* task_runner) 211 base::SingleThreadTaskRunner* task_runner)
220 : BackToBackBeginFrameSource(task_runner), now_src_(now_src) {} 212 : BackToBackBeginFrameSource(task_runner), now_src_(now_src) {}
221 213
214 protected:
222 base::TimeTicks Now() override { return now_src_->NowTicks(); } 215 base::TimeTicks Now() override { return now_src_->NowTicks(); }
223 216
224 // Not owned. 217 // Not owned.
225 base::SimpleTestTickClock* now_src_; 218 base::SimpleTestTickClock* now_src_;
226 }; 219 };
227 220
228 class BackToBackBeginFrameSourceTest : public ::testing::Test { 221 class BackToBackBeginFrameSourceTest : public ::testing::Test {
229 public: 222 public:
230 static const int64_t kDeadline; 223 static const int64_t kDeadline;
231 static const int64_t kInterval; 224 static const int64_t kInterval;
232 225
233 scoped_ptr<base::SimpleTestTickClock> now_src_; 226 scoped_ptr<base::SimpleTestTickClock> now_src_;
234 scoped_refptr<OrderedSimpleTaskRunner> task_runner_; 227 scoped_refptr<OrderedSimpleTaskRunner> task_runner_;
235 scoped_ptr<TestBackToBackBeginFrameSource> source_; 228 scoped_ptr<TestBackToBackBeginFrameSource> source_;
236 scoped_ptr<MockBeginFrameObserver> obs_; 229 scoped_ptr<MockBeginFrameObserver> obs_;
237 230
238 void SetUp() override { 231 void SetUp() override {
239 now_src_.reset(new base::SimpleTestTickClock()); 232 now_src_.reset(new base::SimpleTestTickClock());
240 now_src_->Advance(base::TimeDelta::FromMicroseconds(1000)); 233 now_src_->Advance(base::TimeDelta::FromMicroseconds(1000));
241 task_runner_ = 234 task_runner_ =
242 make_scoped_refptr(new OrderedSimpleTaskRunner(now_src_.get(), false)); 235 make_scoped_refptr(new OrderedSimpleTaskRunner(now_src_.get(), false));
243 source_ = TestBackToBackBeginFrameSource::Create(now_src_.get(), 236 source_.reset(
244 task_runner_.get()); 237 new TestBackToBackBeginFrameSource(now_src_.get(), task_runner_.get()));
245 obs_ = make_scoped_ptr(new ::testing::StrictMock<MockBeginFrameObserver>()); 238 obs_ = make_scoped_ptr(new ::testing::StrictMock<MockBeginFrameObserver>());
246 } 239 }
247 240
248 void TearDown() override { obs_.reset(); } 241 void TearDown() override { obs_.reset(); }
249 }; 242 };
250 243
251 const int64_t BackToBackBeginFrameSourceTest::kDeadline = 244 const int64_t BackToBackBeginFrameSourceTest::kDeadline =
252 BeginFrameArgs::DefaultInterval().ToInternalValue(); 245 BeginFrameArgs::DefaultInterval().ToInternalValue();
253 246
254 const int64_t BackToBackBeginFrameSourceTest::kInterval = 247 const int64_t BackToBackBeginFrameSourceTest::kInterval =
(...skipping 157 matching lines...) Expand 10 before | Expand all | Expand 10 after
412 scoped_ptr<base::SimpleTestTickClock> now_src_; 405 scoped_ptr<base::SimpleTestTickClock> now_src_;
413 scoped_refptr<OrderedSimpleTaskRunner> task_runner_; 406 scoped_refptr<OrderedSimpleTaskRunner> task_runner_;
414 scoped_ptr<TestSyntheticBeginFrameSource> source_; 407 scoped_ptr<TestSyntheticBeginFrameSource> source_;
415 scoped_ptr<MockBeginFrameObserver> obs_; 408 scoped_ptr<MockBeginFrameObserver> obs_;
416 409
417 void SetUp() override { 410 void SetUp() override {
418 now_src_.reset(new base::SimpleTestTickClock()); 411 now_src_.reset(new base::SimpleTestTickClock());
419 now_src_->Advance(base::TimeDelta::FromMicroseconds(1000)); 412 now_src_->Advance(base::TimeDelta::FromMicroseconds(1000));
420 task_runner_ = 413 task_runner_ =
421 make_scoped_refptr(new OrderedSimpleTaskRunner(now_src_.get(), false)); 414 make_scoped_refptr(new OrderedSimpleTaskRunner(now_src_.get(), false));
422 source_ = TestSyntheticBeginFrameSource::Create( 415 source_.reset(new TestSyntheticBeginFrameSource(
423 now_src_.get(), task_runner_.get(), 416 now_src_.get(), task_runner_.get(),
424 base::TimeDelta::FromMicroseconds(10000)); 417 base::TimeDelta::FromMicroseconds(10000)));
425 obs_ = make_scoped_ptr(new MockBeginFrameObserver()); 418 obs_ = make_scoped_ptr(new MockBeginFrameObserver());
426 } 419 }
427 420
428 void TearDown() override { obs_.reset(); } 421 void TearDown() override { obs_.reset(); }
429 }; 422 };
430 423
431 TEST_F(SyntheticBeginFrameSourceTest, 424 TEST_F(SyntheticBeginFrameSourceTest,
432 AddObserverCallsOnBeginFrameWithMissedTick) { 425 AddObserverCallsOnBeginFrameWithMissedTick) {
433 now_src_->Advance(base::TimeDelta::FromMicroseconds(9010)); 426 now_src_->Advance(base::TimeDelta::FromMicroseconds(9010));
434 EXPECT_BEGIN_FRAME_SOURCE_PAUSED(*obs_, false); 427 EXPECT_BEGIN_FRAME_SOURCE_PAUSED(*obs_, false);
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
561 base::TimeDelta::FromInternalValue(10000)); 554 base::TimeDelta::FromInternalValue(10000));
562 now_src_->Advance(base::TimeDelta::FromInternalValue(5000)); 555 now_src_->Advance(base::TimeDelta::FromInternalValue(5000));
563 EXPECT_BEGIN_FRAME_SOURCE_PAUSED(obs, false); 556 EXPECT_BEGIN_FRAME_SOURCE_PAUSED(obs, false);
564 EXPECT_BEGIN_FRAME_USED_MISSED(obs, 10000, 20000, 10000); 557 EXPECT_BEGIN_FRAME_USED_MISSED(obs, 10000, 20000, 10000);
565 source_->AddObserver(&obs); 558 source_->AddObserver(&obs);
566 source_->RemoveObserver(&obs); 559 source_->RemoveObserver(&obs);
567 } 560 }
568 561
569 } // namespace 562 } // namespace
570 } // namespace cc 563 } // namespace cc
OLDNEW
« no previous file with comments | « cc/scheduler/begin_frame_source.cc ('k') | cc/scheduler/scheduler_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698