Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4144)

Unified Diff: cc/test/scheduler_test_common.h

Issue 1840223002: cc: Remove BeginFrameSource::Create methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test BFS and mus too Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/surfaces/onscreen_display_client.cc ('k') | cc/test/scheduler_test_common.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/test/scheduler_test_common.h
diff --git a/cc/test/scheduler_test_common.h b/cc/test/scheduler_test_common.h
index eac4983a6596283348d25fc1b0370d6b2b89d394..788b6835248a670b8be23da25f392aa324882038 100644
--- a/cc/test/scheduler_test_common.h
+++ b/cc/test/scheduler_test_common.h
@@ -118,19 +118,11 @@ class FakeBeginFrameSource : public BeginFrameSourceBase {
class TestBackToBackBeginFrameSource : public BackToBackBeginFrameSource {
public:
- ~TestBackToBackBeginFrameSource() override;
-
- static scoped_ptr<TestBackToBackBeginFrameSource> Create(
- base::SimpleTestTickClock* now_src,
- base::SingleThreadTaskRunner* task_runner) {
- return make_scoped_ptr(
- new TestBackToBackBeginFrameSource(now_src, task_runner));
- }
-
- protected:
TestBackToBackBeginFrameSource(base::SimpleTestTickClock* now_src,
base::SingleThreadTaskRunner* task_runner);
+ ~TestBackToBackBeginFrameSource() override;
+ protected:
base::TimeTicks Now() override;
// Not owned.
base::SimpleTestTickClock* now_src_;
@@ -141,23 +133,11 @@ class TestBackToBackBeginFrameSource : public BackToBackBeginFrameSource {
class TestSyntheticBeginFrameSource : public SyntheticBeginFrameSource {
public:
+ explicit TestSyntheticBeginFrameSource(base::SimpleTestTickClock* now_src,
+ OrderedSimpleTaskRunner* task_runner,
+ base::TimeDelta initial_interval);
~TestSyntheticBeginFrameSource() override;
- static scoped_ptr<TestSyntheticBeginFrameSource> Create(
- base::SimpleTestTickClock* now_src,
- OrderedSimpleTaskRunner* task_runner,
- base::TimeDelta initial_interval) {
- scoped_ptr<TestDelayBasedTimeSource> time_source =
- TestDelayBasedTimeSource::Create(now_src, initial_interval,
- task_runner);
- return make_scoped_ptr(
- new TestSyntheticBeginFrameSource(std::move(time_source)));
- }
-
- protected:
- explicit TestSyntheticBeginFrameSource(
- scoped_ptr<DelayBasedTimeSource> time_source);
-
private:
DISALLOW_COPY_AND_ASSIGN(TestSyntheticBeginFrameSource);
};
« no previous file with comments | « cc/surfaces/onscreen_display_client.cc ('k') | cc/test/scheduler_test_common.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698