Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: cc/scheduler/begin_frame_source.h

Issue 1840223002: cc: Remove BeginFrameSource::Create methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test BFS and mus too Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/scheduler/begin_frame_source.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/scheduler/begin_frame_source.h
diff --git a/cc/scheduler/begin_frame_source.h b/cc/scheduler/begin_frame_source.h
index 1efd6a1bda6d22d8b333de632e66780eb00caabf..fb0c8c3f40c14b5fd5daa0efed4a82432d2c9129 100644
--- a/cc/scheduler/begin_frame_source.h
+++ b/cc/scheduler/begin_frame_source.h
@@ -178,7 +178,7 @@ class CC_EXPORT BeginFrameSourceBase : public BeginFrameSource {
// remaining frames reaches zero.
class CC_EXPORT BackToBackBeginFrameSource : public BeginFrameSourceBase {
public:
- static scoped_ptr<BackToBackBeginFrameSource> Create(
+ explicit BackToBackBeginFrameSource(
base::SingleThreadTaskRunner* task_runner);
~BackToBackBeginFrameSource() override;
@@ -193,8 +193,6 @@ class CC_EXPORT BackToBackBeginFrameSource : public BeginFrameSourceBase {
void AsValueInto(base::trace_event::TracedValue* dict) const override;
protected:
- explicit BackToBackBeginFrameSource(
- base::SingleThreadTaskRunner* task_runner);
virtual base::TimeTicks Now(); // Now overridable for testing
base::SingleThreadTaskRunner* task_runner_;
@@ -214,9 +212,10 @@ class CC_EXPORT BackToBackBeginFrameSource : public BeginFrameSourceBase {
class CC_EXPORT SyntheticBeginFrameSource : public BeginFrameSourceBase,
public DelayBasedTimeSourceClient {
public:
- static scoped_ptr<SyntheticBeginFrameSource> Create(
- base::SingleThreadTaskRunner* task_runner,
- base::TimeDelta initial_vsync_interval);
+ explicit SyntheticBeginFrameSource(base::SingleThreadTaskRunner* task_runner,
+ base::TimeDelta initial_vsync_interval);
+ explicit SyntheticBeginFrameSource(
+ scoped_ptr<DelayBasedTimeSource> time_source);
~SyntheticBeginFrameSource() override;
void OnUpdateVSyncParameters(base::TimeTicks new_vsync_timebase,
@@ -233,9 +232,6 @@ class CC_EXPORT SyntheticBeginFrameSource : public BeginFrameSourceBase,
void OnTimerTick() override;
protected:
- explicit SyntheticBeginFrameSource(
- scoped_ptr<DelayBasedTimeSource> time_source);
-
BeginFrameArgs CreateBeginFrameArgs(base::TimeTicks frame_time,
BeginFrameArgs::BeginFrameArgsType type);
« no previous file with comments | « no previous file | cc/scheduler/begin_frame_source.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698