Move DisplayLayout and DisplayLayoutBuilder From ash To ui/display

Move DisplayLayout and DisplayLayoutBuilder From ash To ui/display

BUG=595498
Committed: https://crrev.com/c0dfd6b2d5be7951bc1dfa61053f67d2514889f5
Cr-Commit-Position: refs/heads/master@{#385875}

[robliao, 2016-03-28 16:58:40]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-28 16:58:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1838833002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1838833002/1

[commit-bot: I haz the power, 2016-03-28 17:01:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-28 17:01:05]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[robliao, 2016-03-28 19:38:10]

Patchset #1 (id:1) has been deleted

[robliao, 2016-03-28 19:38:19]

Patchset #1 (id:20001) has been deleted

[robliao, 2016-03-28 19:38:26]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-28 19:38:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1838833002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1838833002/40001

[commit-bot: I haz the power, 2016-03-28 20:18:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-28 20:18:42]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[robliao, 2016-03-29 20:48:27]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[robliao, 2016-03-29 20:48:35]

Patchset #1 (id:40001) has been deleted

[commit-bot: I haz the power, 2016-03-29 20:49:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1838833002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1838833002/60001

[robliao, 2016-03-29 21:05:02]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-29 21:05:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1838833002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1838833002/80001

[robliao, 2016-03-29 23:46:09]

The CQ bit was unchecked by robliao@chromium.org

[robliao, 2016-03-29 23:47:26]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[robliao, 2016-03-29 23:47:36]

Patchset #1 (id:60001) has been deleted

[robliao, 2016-03-29 23:47:44]

Patchset #1 (id:80001) has been deleted

[commit-bot: I haz the power, 2016-03-29 23:48:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1838833002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1838833002/100001

[commit-bot: I haz the power, 2016-03-30 07:22:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-30 07:22:31]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[robliao, 2016-03-30 18:28:52]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-30 18:29:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1838833002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1838833002/120001

[commit-bot: I haz the power, 2016-03-30 20:11:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-30 20:11:02]

Dry run: This issue passed the CQ dry run.

[robliao, 2016-03-30 21:02:25]

Patchset #1 (id:100001) has been deleted

[robliao, 2016-03-30 21:08:27]

robliao@chromium.org changed reviewers:
+ oshima@chromium.org

[robliao, 2016-03-30 21:08:28]

oshima: Please review this change. Thanks!

[robliao, 2016-04-01 17:02:40]

On 2016/03/30 21:08:28, robliao wrote:
> oshima: Please review this change. Thanks!

Ping. Thanks!

[robliao, 2016-04-04 19:26:07]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-04 19:26:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1838833002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1838833002/120001

[commit-bot: I haz the power, 2016-04-04 19:45:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-04 19:45:53]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[robliao, 2016-04-05 00:14:35]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[robliao, 2016-04-05 00:14:56]

Updated to 1c9b022 and Fixed Newly Added Code Impacted by Breaking Change

[commit-bot: I haz the power, 2016-04-05 00:14:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1838833002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1838833002/140001

[commit-bot: I haz the power, 2016-04-05 00:20:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-05 00:20:57]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[robliao, 2016-04-05 16:51:10]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-05 16:51:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1838833002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1838833002/140001

[commit-bot: I haz the power, 2016-04-05 17:55:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-05 17:55:45]

Dry run: This issue passed the CQ dry run.

[robliao, 2016-04-05 20:45:01]

On 2016/04/05 17:55:45, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

Ping. Thanks!

[robliao, 2016-04-07 19:19:58]

On 2016/04/05 20:45:01, robliao wrote:
> On 2016/04/05 17:55:45, commit-bot: I haz the power wrote:
> > Dry run: This issue passed the CQ dry run.
> 
> Ping. Thanks!

Is there an ETA for this review? Thanks.

[oshima, 2016-04-07 19:54:21]

thank you for working on this. just nits.

lgtm

https://codereview.chromium.org/1838833002/diff/140001/ui/display/manager/dis...
File ui/display/manager/display_layout.cc (right):

https://codereview.chromium.org/1838833002/diff/140001/ui/display/manager/dis...
ui/display/manager/display_layout.cc:256: }  // namespace gfx
display

https://codereview.chromium.org/1838833002/diff/140001/ui/display/manager/dis...
File ui/display/manager/display_layout.h (right):

https://codereview.chromium.org/1838833002/diff/140001/ui/display/manager/dis...
ui/display/manager/display_layout.h:1: // Copyright 2016 The Chromium Authors.
All rights reserved.
I think we don't update when just moving the file, although you may leave it if
you want.

[robliao, 2016-04-07 20:10:20]

robliao@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org, stevenjb@chromium.org

[robliao, 2016-04-07 20:10:21]

Thanks for the review!
Additional OWNERS: Please provide owner approval for the paths under your email.
Thanks!

stevenjb@chromium.org: 
chrome/browser/ui/webui/options/chromeos/display_options_handler.cc

rdevlin.cronin@chromium.org: 
chrome/browser/extensions/*

https://codereview.chromium.org/1838833002/diff/140001/ui/display/manager/dis...
File ui/display/manager/display_layout.cc (right):

https://codereview.chromium.org/1838833002/diff/140001/ui/display/manager/dis...
ui/display/manager/display_layout.cc:256: }  // namespace gfx
On 2016/04/07 19:54:21, oshima wrote:
> display

Done.

https://codereview.chromium.org/1838833002/diff/140001/ui/display/manager/dis...
File ui/display/manager/display_layout.h (right):

https://codereview.chromium.org/1838833002/diff/140001/ui/display/manager/dis...
ui/display/manager/display_layout.h:1: // Copyright 2016 The Chromium Authors.
All rights reserved.
On 2016/04/07 19:54:21, oshima wrote:
> I think we don't update when just moving the file, although you may leave it
if
> you want.

The format was wrong, so I'll keep the change.

[robliao, 2016-04-07 20:10:52]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-07 20:11:17]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1838833002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1838833002/160001

[Devlin, 2016-04-07 20:40:19]

c/b/extensions lgtm

[oshima, 2016-04-07 20:59:28]

slgtm

https://codereview.chromium.org/1838833002/diff/140001/ui/display/manager/dis...
File ui/display/manager/display_layout.h (right):

https://codereview.chromium.org/1838833002/diff/140001/ui/display/manager/dis...
ui/display/manager/display_layout.h:1: // Copyright 2016 The Chromium Authors.
All rights reserved.
On 2016/04/07 20:10:21, robliao wrote:
> On 2016/04/07 19:54:21, oshima wrote:
> > I think we don't update when just moving the file, although you may leave it
> if
> > you want.
> 
> The format was wrong, so I'll keep the change.

That was the valid format back then. just fyi.

[stevenjb, 2016-04-07 21:05:17]

c/b lgtm

[robliao, 2016-04-07 21:13:49]

https://codereview.chromium.org/1838833002/diff/140001/ui/display/manager/dis...
File ui/display/manager/display_layout.h (right):

https://codereview.chromium.org/1838833002/diff/140001/ui/display/manager/dis...
ui/display/manager/display_layout.h:1: // Copyright 2016 The Chromium Authors.
All rights reserved.
On 2016/04/07 20:59:28, oshima wrote:
> On 2016/04/07 20:10:21, robliao wrote:
> > On 2016/04/07 19:54:21, oshima wrote:
> > > I think we don't update when just moving the file, although you may leave
it
> > if
> > > you want.
> > 
> > The format was wrong, so I'll keep the change.
> 
> That was the valid format back then. just fyi.

Good to know. Thanks for the info!

[commit-bot: I haz the power, 2016-04-07 21:19:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-07 21:19:27]

Dry run: This issue passed the CQ dry run.

[robliao, 2016-04-07 21:24:29]

The CQ bit was checked by robliao@chromium.org

[robliao, 2016-04-07 21:24:30]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/1838833002/#ps160001
(title: "Fix comment")

[commit-bot: I haz the power, 2016-04-07 21:26:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1838833002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1838833002/160001

[commit-bot: I haz the power, 2016-04-07 21:34:06]

Committed patchset #3 (id:160001)

[commit-bot: I haz the power, 2016-04-07 21:35:20]

Description was changed from

==========
Move DisplayLayout and DisplayLayoutBuilder From ash To ui/display

BUG=595498
==========

to

==========
Move DisplayLayout and DisplayLayoutBuilder From ash To ui/display

BUG=595498

Committed: https://crrev.com/c0dfd6b2d5be7951bc1dfa61053f67d2514889f5
Cr-Commit-Position: refs/heads/master@{#385875}
==========

[commit-bot: I haz the power, 2016-04-07 21:35:22]

Patchset 3 (id:??) landed as
https://crrev.com/c0dfd6b2d5be7951bc1dfa61053f67d2514889f5
Cr-Commit-Position: refs/heads/master@{#385875}